practice bootcamp adding 404 and 500 #198
Conversation
✅ Deploy Preview for tartanhacks-registration ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-tartanhacks-registration ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Great job! I left a couple of comments about some very minor changes. Once those are fixed, this should be good to merge! VSCode has a tab on the left that shows the files you are about to stage or commit, this should help with fixing the line ending issue |
| import Menu from "src/components/menu/Menu" | ||
| import styles from "../styles/404.module.scss" | ||
|
|
||
| const ApplicationPage: NextPage = (): ReactElement => { |
There was a problem hiding this comment.
This function is not actually used - it can be removed
| import Menu from "src/components/menu/Menu" | ||
| import styles from "../styles/500.module.scss" | ||
|
|
||
| const ApplicationPage: NextPage = (): ReactElement => { |
There was a problem hiding this comment.
Same goes for this function - it is not used so it can be removed safely
| @import "./variables.scss"; | ||
| @import "./mixins.scss"; | ||
|
|
||
| .background { |
There was a problem hiding this comment.
Very good! One thing - it seems like you use the same styles for your 404 and 500 pages. It is better to avoid duplication whenever possible - one solution would be to just use one file, eg errorPage.module.scss, that you would import in both 404.tsx and 500.tsx.
practice for the bootcamp that creates pages 404 and 500 for the registration website!
Closes #107
Type of change
How Has This Been Tested?
i did not test the 500 page. i did test the 404 page by going to a invalid URL.
Test Configuration:
Checklist: