chore(release): Bump to version 0.5.3 #6257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctDir` if it is empty (#6092) Co-authored-by: Hsiao-nan Cheung <[email protected]>
Co-authored-by: Hsiao-nan Cheung <[email protected]>
Signed-off-by: Chawye Hsu <[email protected]>
5 tasks
|
@ScoopInstaller/maintainers Anyone could review this PR? |
chawyehsu
reviewed
Jan 10, 2025
| " set args=$quoted_arg %*", | ||
| ' setlocal enabledelayedexpansion', | ||
| ' if not "!args!"=="" set args=!args:"=""!', | ||
| " bash -c `"`$(cygpath -u '$resolved_path') !args!`"", |
There was a problem hiding this comment.
This change on the shim function looks critical, can we have some tests for it?
Everything else seems trivial.
There was a problem hiding this comment.
@sitiom Take a look here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Bug Fixes
Expand-7zipArchiveonly delete temp dir /$extractDirif it is empty (fix (decompress):Expand-7zipArchiveonly delete temp dir /$extractDirif it is empty #6092)stderr, properly checkwslpath/cygpathcommand first (fix(shim): properly checkwslpath/cygpathcommand first #6114)no_junctionenvs (fix(scoop-bucket): Add missing import forno_junctionenvs #6181)Code Refactoring
Performance Improvements
Close Issues
Credits
Thanks to the following contributors (ordered by PR merging time):
@o-l-a-v @niheaven @kiennq @HUMORCE @sitiom @chawyehsu