-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for rubocop-rspec 0.20.1 #70
Conversation
But I strongly recommend removing rubocop from the gemspec. |
I strongly recommend NOT to. As SciRuby basically lives on students/novice contributions, automatical style check is a blessing. The trick is, rubocop (and rubocop-rspec especially) is not a God's Voice and can be easily set up as we like it. So, in this case, you could just disable this new cop in On the other hand, I believe that this suggestion (that context description should look like "context: when/with " not "context: does ") is pretty meaningful and good to guard. On the third hand (yep feeling a bit like Shiva today) fixing it mechanically, like this PR does, brings no value. For ex.: - context 'writes convert_comma only on float values' do
+ context 'when writes convert_comma only on float values' do The latter reads really weird. The "proper" fix for this cop is, in fact: - context 'writes convert_comma only on float values' do
+ describe ':convert_comma option' do ...but fixing things this way will take a lot of time. So, what I suggest in fact is:
RSpec/ContextWording:
Enabled: false
As an outtake: Rubocop brings value, but mechanical following the cops does not. |
Absolutely! Rule of thumb with new Rubocop cops, that emerged in the new version and suddenly offended by half of the codebase:
|
Who can merge this pull-request? |
I was waiting for @zverok to do the deed, but I'll do it now. 😄 |
@athityakumar @zverok thanks!! |
Before #68, fixes against rubocop-rspec 0.20.1 needs to be merged.