Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds from, read, write, to_s methods #52

Merged
merged 15 commits into from
Aug 31, 2017
Merged

Adds from, read, write, to_s methods #52

merged 15 commits into from
Aug 31, 2017

Commits on Aug 25, 2017

  1. Starts adding to_s, from, read and write methods 

    The to_format method is pending, and is quite ambigous as in , returning which format instance would make more sense. Also, the YARD docs is yet to be updated as it's been updated for  markdown support in PR #50 and would be better to proceed after that PR is merged.
    @athityakumar
    athityakumar committed Aug 25, 2017
    Configuration menu
    Copy the full SHA
    a96fcb8 View commit details
    Browse the repository at this point in the history

  2. Adds minor rubocop fixes

    @athityakumar
    athityakumar committed Aug 25, 2017
    Configuration menu
    Copy the full SHA
    497b50d View commit details
    Browse the repository at this point in the history

  3. Fixes JSON, CSV & XLSX rspec tests 

    Minor arguments issue for remote files parsing
    @athityakumar
    athityakumar committed Aug 25, 2017
    Configuration menu
    Copy the full SHA
    65783ea View commit details
    Browse the repository at this point in the history

  4. Fixes minor Mongo to JSON linking issue

    @athityakumar
    athityakumar committed Aug 25, 2017
    Configuration menu
    Copy the full SHA
    3cbddba View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2017

  1. Merge branch 'master' into read-write-s-methods

    @athityakumar
    athityakumar authored Aug 26, 2017
    Configuration menu
    Copy the full SHA
    a0e986c View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2017

  1. Documents all Exporter methods

    @athityakumar
    athityakumar committed Aug 28, 2017
    Configuration menu
    Copy the full SHA
    a060cf4 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2017

  1. Documents all Importer methods

    @athityakumar
    athityakumar committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    348111b View commit details
    Browse the repository at this point in the history

  2. Changes README documentation

    @athityakumar
    athityakumar committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    d0fe35d View commit details
    Browse the repository at this point in the history

  3. Fixes minor rubocop offense

    @athityakumar
    athityakumar committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    5b39712 View commit details
    Browse the repository at this point in the history

  4. Fixes minor rspec issue

    @athityakumar
    athityakumar committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    b376af1 View commit details
    Browse the repository at this point in the history

  5. Adds a very minor change to README

    @athityakumar
    athityakumar committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    823b024 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2017

  1. Changes importer.new(opts).read(path) calls to importer.read(path).ca… 

    …ll(opts)

Rubocop, YARD Docs & README are still a mess. But nevertheless, there's a great deal of code porting that has been done, and I NEVER want to have any of these changes accidentally reverted. RSpec is passing. 🎉
    @athityakumar
    athityakumar committed Aug 30, 2017
    Configuration menu
    Copy the full SHA
    ebd5706 View commit details
    Browse the repository at this point in the history

  2. Adds changes that makes Rubocop & YARD docs happy

    @athityakumar
    athityakumar committed Aug 30, 2017
    Configuration menu
    Copy the full SHA
    8d63e49 View commit details
    Browse the repository at this point in the history

  3. Adds Importer doc changes to README

    @athityakumar
    athityakumar committed Aug 30, 2017
    Configuration menu
    Copy the full SHA
    b3ccf4c View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2017

  1. Adds @method tag for all Importers' YARD docs

    @athityakumar
    athityakumar committed Aug 31, 2017
    Configuration menu
    Copy the full SHA
    5e7ead9 View commit details
    Browse the repository at this point in the history