Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force init #194

Merged
merged 2 commits into from
Feb 2, 2025
Merged

Force init #194

merged 2 commits into from
Feb 2, 2025

Conversation

Beforerr
Copy link
Contributor

Added a force parameter to each of the initialization functions.
This parameter allows you to force the initialization of providers even if disabled by config (init_amda, init_csa, init_cdaweb, init_sscweb, and init_archive).

This parameter allows you to force the initialization of providers (init_amda, init_csa, init_cdaweb, init_sscweb, and init_archive).
@jeandet
Copy link
Member

jeandet commented Jan 31, 2025

@Beforerr thank you for the PR, I think this option should use a more explicit name than force because it can be misleading since provider initialization is mainly inventory update then load and in this context it could mean "ignore cached data".
Maybe something like include_disabled?

@Beforerr
Copy link
Contributor Author

If explicit, I suggest renaming it to ignore_disabled_status (ignoring a status check rather than including something)

@jeandet
Copy link
Member

jeandet commented Jan 31, 2025

If explicit, I suggest renaming it to ignore_disabled_status (ignoring a status check rather than including something)

That works for me too 👍.

Copy link

sonarqubecloud bot commented Feb 1, 2025

Copy link
Member

@jeandet jeandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@jeandet jeandet merged commit f99d990 into SciQLop:main Feb 2, 2025
21 of 23 checks passed
@Beforerr Beforerr deleted the force_init branch February 4, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants