Enabling RODE handling #585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
format |
|
|
||
| # sum(abs2,inner_loss(t,θ) for t in ts) but Zygote generators are broken | ||
| println(typeof(W)) |
There was a problem hiding this comment.
Suggested change
| println(typeof(W)) |
|
added in #882 |
|
Is it correct though? The original formulation here is not correct as it's only with respect to a single brownian path |
|
To clarify, I re-enabled the old implementation updating it from the FastChain days and ran the existing tests on it |
|
Yes that is not a correct implementation and should not be added. |
|
commented it out |
|
Just delete it. It needs to be started fresh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #563 on a first pass.