Merge pull request #2944 from SciML/myb/exp

Experimental variable filtering in dummy derivative

docs/src/basics/InputOutput.md

@@ -34,10 +34,8 @@ This function takes a vector of variables that are to be considered inputs, i.e.
 
 ### Example:
 
-
 The following example implements a simple first-order system with an input `u` and state `x`. The function `f` is generated using `generate_control_function`, and the function `f` is then tested with random input and state values.
 
-
 ```@example inputoutput
 import ModelingToolkit: t_nounits as t, D_nounits as D
 @variables x(t)=0 u(t)=0 y(t)
@@ -50,10 +48,8 @@ f, x_sym, ps = ModelingToolkit.generate_control_function(sys, [u], simplify = tr
 nothing # hide
 ```
 
-
 We can inspect the state realization chosen by MTK
 
-
 ```@example inputoutput
 x_sym
 ```
@@ -70,7 +66,6 @@ nothing  # hide
 
 Now we can test the generated function `f` with random input and state values
 
-
 ```@example inputoutput
 p = [1]
 x = [rand()]

src/structural_transformation/partial_state_selection.jl

@@ -216,18 +216,23 @@ function dummy_derivative_graph!(
     col_order = Int[]
     nvars = ndsts(graph)
     eqs = Int[]
+    vars = Int[]
     next_eq_idxs = Int[]
     next_var_idxs = Int[]
     new_eqs = Int[]
     new_vars = Int[]
     eqs_set = BitSet()
-    for vars in var_sccs
+    for vars′ in var_sccs
         empty!(eqs)
-        for var in vars
+        empty!(vars)
+        for var in vars′
             eq = var_eq_matching[var]
             eq isa Int || continue
-            diff_to_eq[eq] === nothing && continue
-            push!(eqs, eq)
+            diff_to_eq[eq] === nothing || push!(eqs, eq)
+            if var_to_diff[var] !== nothing
+                error("Invalid SCC")
+            end
+            (diff_to_var[var] !== nothing && is_present(structure, var)) && push!(vars, var)
         end
         isempty(eqs) && continue
 
@@ -318,6 +323,8 @@ function dummy_derivative_graph!(
             for (i, var) in enumerate(vars)
                 ∫var = diff_to_var[var]
                 ∫var === nothing && continue
+                ∫∫var = diff_to_var[∫var]
+                ∫∫var === nothing && continue
                 if J !== nothing
                     push!(next_var_idxs, i)
                 end