Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve PresetTimeCallback #234

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

albertomercurio
Copy link
Contributor

@albertomercurio albertomercurio commented Oct 15, 2024

This PR removes spurious memory allocations of PresetTimeCallback.

I tried to run the test locally, but I got

┌ Warning: Could not use exact versions of packages in manifest, re-resolving
└ @ Pkg.Operations ~/.julia/juliaup/julia-1.11.0+0.x64.linux.gnu/share/julia/stdlib/v1.11/Pkg/src/Operations.jl:1900
ERROR: Unsatisfiable requirements detected for package SciMLSensitivity [1ed8b502]:
 SciMLSensitivity [1ed8b502] log:
 ├─possible versions are: 7.0.0 - 7.68.0 or uninstalled
 ├─restricted to versions 7.68.0 - 7 by an explicit requirement, leaving only versions: 7.68.0
 └─restricted by compatibility requirements with DiffEqCallbacks [459566f4] to versions: uninstalled — no versions left
   └─DiffEqCallbacks [459566f4] log:
     ├─possible versions are: 4.0.0 or uninstalled
     └─DiffEqCallbacks [459566f4] is fixed to version 4.0.0

with both Julia 1.10 and 1.11.

This error shouldn't be related to this changes.

@albertomercurio
Copy link
Contributor Author

Ok, now thee test was able to run, and everything is fine.

src/preset_time.jl Outdated Show resolved Hide resolved
@ChrisRackauckas
Copy link
Member

Rebase this so we can see the tests on LTS

@albertomercurio
Copy link
Contributor Author

Ok done.

@ChrisRackauckas ChrisRackauckas merged commit e562cf6 into SciML:master Oct 21, 2024
15 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants