Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OrdinaryDiffEqCore weakdep #232

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

isaacsas
Copy link
Member

@isaacsas isaacsas commented Sep 3, 2024

I don't know if this is the version to use, or if something more is required (like updating the registry manually).

@isaacsas isaacsas changed the title add OrdinaryDiffEqCore dep add OrdinaryDiffEqCore weakdep Sep 3, 2024
@ChrisRackauckas ChrisRackauckas merged commit edac700 into SciML:master Sep 3, 2024
7 of 9 checks passed
@isaacsas isaacsas deleted the ordiffeqcoredep branch September 3, 2024 21:06
@ChrisRackauckas
Copy link
Member

We might want to yank the previous release or put this bound on it.

@isaacsas
Copy link
Member Author

isaacsas commented Sep 3, 2024

Whatever you want to do. I’m not sure what that would entail (a PR that modifies the general registry in some way I assume)?

@isaacsas
Copy link
Member Author

isaacsas commented Sep 3, 2024

Do we know that this fixes @baggepinnen’s issue?

@ChrisRackauckas
Copy link
Member

it would need a registry yank on the last release to force it, but other than that it should.

@isaacsas
Copy link
Member Author

isaacsas commented Sep 4, 2024

Can you make a 3.9.1 release then? I’ll make the PR to yank 3.9 now.

@isaacsas
Copy link
Member Author

isaacsas commented Sep 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants