Skip to content

Commit

Permalink
chore: enable TypeScript strict mode in end-to-end tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Marcarrian authored and danielwiehl committed Jul 25, 2023
1 parent 32a2e86 commit ea6c043
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 10 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@

"components:lint": "ng lint @scion/components",
"components:test": "ng test @scion/components",
"components:e2e:run": "cross-env PLAYWRIGHT_BROWSERS_PATH=0 playwright test --config=projects/scion/components.e2e/playwright.config.ts",
"components:e2e:debug": "cross-env PLAYWRIGHT_BROWSERS_PATH=0 PWDEBUG=1 playwright test --config=projects/scion/components.e2e/playwright.config.ts",
"components:e2e:run": "tsc --incremental -p projects/scion/components.e2e/tsconfig.json && cross-env PLAYWRIGHT_BROWSERS_PATH=0 playwright test --config out-tsc/components.e2e",
"components:e2e:debug": "tsc --incremental -p projects/scion/components.e2e/tsconfig.json && cross-env PLAYWRIGHT_BROWSERS_PATH=0 PWDEBUG=1 playwright test --config out-tsc/components.e2e",
"components:e2e:lint": "ng lint @scion/components.e2e",
"components:build": "ng build --configuration production @scion/components",
"components:changelog": "conventional-changelog --commit-path projects/scion/components -k projects/scion/components -t components- -p angular -i CHANGELOG_COMPONENTS.md -s && markdown-include docs/site/changelog-components/changelog.template.json",
Expand Down
2 changes: 1 addition & 1 deletion projects/scion/components.e2e/playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@ const config: PlaywrightTestConfig = {
},
},
maxFailures: runInCI ? 1 : undefined,
testMatch: /.*\.e2e-spec\.ts/,
testMatch: /.*\.e2e-spec\.js/,
};
export default config;
19 changes: 12 additions & 7 deletions projects/scion/components.e2e/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
/* See https://playwright.dev/docs/test-typescript#tsconfigjson */
{
"extends" : "../../../tsconfig.json",
"compilerOptions" : {
"outDir" : "../../../out-tsc/components.e2e",
"module" : "ES2022",
"target" : "ES2022",
"strict" : true
"compilerOptions": {
"baseUrl": "../../../",
"outDir": "../../../out-tsc/components.e2e",
"module": "commonjs",
"sourceMap": true,
"strict": true,
"experimentalDecorators": true,
"moduleResolution": "node",
"target": "es2020",
"types": [
"node"
],
}
}

0 comments on commit ea6c043

Please sign in to comment.