Skip to content

Commit

Permalink
ci: fix creating GitHub release notes
Browse files Browse the repository at this point in the history
Previously, releasing to GitHub failed because we did not declare a dependency on the 'build-libs' step, required to initialize the $VERSION variable.
  • Loading branch information
Marcarrian authored and danielwiehl committed Oct 9, 2023
1 parent 6550f9d commit 98ab322
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,9 @@ jobs:
release-toolkit:
name: 'Releasing @scion/toolkit'
if: ${{ needs.toolkit-release-guard.outputs.should-release == 'true' }}
needs: toolkit-release-guard
needs:
- build-libs
- toolkit-release-guard
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -300,7 +302,9 @@ jobs:
release-components:
name: 'Releasing @scion/components'
if: ${{ needs.components-release-guard.outputs.should-release == 'true' }}
needs: components-release-guard
needs:
- build-libs
- components-release-guard
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down

0 comments on commit 98ab322

Please sign in to comment.