Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forms): add demo for validation behavior #9

Closed
wants to merge 30 commits into from
Closed

feat(forms): add demo for validation behavior #9

wants to merge 30 commits into from

Conversation

BoppLi
Copy link
Contributor

@BoppLi BoppLi commented Jan 2, 2024

No description provided.

@larsrickert larsrickert changed the title feat: crate forms demo example for validation behavior feat: create forms demo example for validation behavior Jan 2, 2024
larsrickert
larsrickert requested changes Jan 2, 2024
View reviewed changes
apps/docs/src/.env.example Outdated Show resolved Hide resolved
apps/docs/src/.env.example Outdated Show resolved Hide resolved
packages/sit-onyx/src/components/TestInput/TestInput.vue Outdated Show resolved Hide resolved
packages/sit-onyx/src/components/TestInput/TestInput.vue Outdated Show resolved Hide resolved
packages/sit-onyx/src/demos/FormDemo/FormDemo.vue Outdated Show resolved Hide resolved
@BoppLi
Copy link
Contributor Author

BoppLi commented Jan 2, 2024

should the PR title be rather feat(demo): create?

@larsrickert
Copy link
Collaborator

should the PR title be rather feat(demo): create?

It think the current title is fine or something like feat(forms): add demo story

@BoppLi BoppLi changed the title feat: create forms demo example for validation behavior feat(forms): add demo story for validation behavior Jan 3, 2024
@BoppLi BoppLi changed the title feat(forms): add demo story for validation behavior feat(forms): add demo for validation behavior Jan 3, 2024
@BoppLi BoppLi marked this pull request as ready for review January 3, 2024 16:35
@BoppLi BoppLi requested a review from JoCa96 as a code owner January 3, 2024 16:35
@BoppLi BoppLi added this to the Setup milestone Jan 3, 2024
@BoppLi BoppLi linked an issue Jan 3, 2024 that may be closed by this pull request
Research forms and their validation #39
Closed
@BoppLi
Copy link
Contributor Author

BoppLi commented Jan 4, 2024

Add doc for minleght: prefilled values will not invalidate

@BoppLi
Copy link
Contributor Author

BoppLi commented Jan 4, 2024

todo: provide translations for the common languages for the error cases and let the projects pass a lang key

@BoppLi
Copy link
Contributor Author

BoppLi commented Jan 4, 2024

create playwright tests for each validation message (without screenshot)

@BoppLi BoppLi marked this pull request as draft January 4, 2024 10:12
@BoppLi BoppLi removed this from the Setup milestone Jan 4, 2024
@BoppLi BoppLi closed this Jan 5, 2024
@larsrickert larsrickert deleted the feat/forms-demo branch August 2, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsrickert larsrickert larsrickert requested changes

@JoCa96 JoCa96 Awaiting requested review from JoCa96

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Research forms and their validation
2 participants
@BoppLi @larsrickert