feat(OnyxHeadline): support showAs property
#2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bf0d335 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <[email protected]>
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <[email protected]>
JoCa96
approved these changes
Jan 23, 2025
larsrickert
changed the title
visualSize propertyshowAs property
JoCa96
pushed a commit
that referenced
this pull request
Jan 30, 2025
Relates to #2451 Add new `showAs` property to allow defining a different visual size instead of the semantical type. ## Checklist - [x] The added / edited code has been documented with [JSDoc](https://jsdoc.app/about-getting-started) - [x] All changes are documented in the documentation app (folder `apps/docs`) - [x] If a new component is added, at least one [Playwright screenshot test](https://github.com/SchwarzIT/onyx/actions/workflows/playwright-screenshots.yml) is added - [x] A changeset is added with `npx changeset add` if your changes should be released as npm package (because they affect the library usage) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2451
Add new
showAsproperty to allow defining a different visual size instead of the semantical type.Checklist
apps/docs)npx changeset addif your changes should be released as npm package (because they affect the library usage)