Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(OnyxAccordion): implement review feedback #2570

Merged
merged 3 commits into from
Jan 22, 2025
Merged

feat(OnyxAccordion): implement review feedback #2570

merged 3 commits into from
Jan 22, 2025

Conversation

ChristianBusshoff
Copy link
Contributor

  • emit open state
  • skeleton can be a number
  • changing the exclusive mode is closing all open accordions

@ChristianBusshoff ChristianBusshoff requested a review from a team as a code owner January 21, 2025 15:02
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b5985d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@larsrickert larsrickert self-assigned this Jan 21, 2025
@ChristianBusshoff ChristianBusshoff added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@ChristianBusshoff ChristianBusshoff added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 66d682f Jan 22, 2025
20 checks passed
@ChristianBusshoff ChristianBusshoff deleted the feat-2140/implement-onyx-accordion-review-feedback branch January 22, 2025 07:49
JoCa96 pushed a commit that referenced this pull request Jan 30, 2025
@ChristianBusshoff @JoCa96
feat(OnyxAccordion): implement review feedback (#2570)
e41bf1d 
- emit open state
- skeleton can be a number
- changing the exclusive mode is closing all open accordions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsrickert larsrickert larsrickert approved these changes

Assignees

@larsrickert larsrickert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristianBusshoff @larsrickert