fix: Incorrect chart values for user, group and memory limit #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianmarco-mameli
force-pushed
the
fix_incorrect_values
branch
from
56b1c8e to
01db96c
Compare
dirien
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Hey @gianmarco-mameli,
Thanks for the PR. Could you revert the runAsUser/Group values and we are good to go to merge.
dirien
requested changes
Aug 13, 2024
|
can you please run |
|
Hi @dirien, no problem, I'm trying to solve the action on DCO but seems that your command, and the commands suggested from the DCO aren't working. |
|
I would say now rebase the main branch into this branch, then |
gianmarco-mameli
force-pushed
the
fix_incorrect_values
branch
2 times, most recently
from
b1e0a3e to
58e0e3a
Compare
|
I think it's still blocked, sorry for this mess |
dirien
force-pushed
the
fix_incorrect_values
branch
4 times, most recently
from
e753974 to
442a60d
Compare
Signed-off-by: Gianmarco Mameli <[email protected]>
dirien
force-pushed
the
fix_incorrect_values
branch
from
442a60d to
bf5907b
Compare
|
@gianmarco-mameli Fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #343
Fixed chart values for user, group and memory limit