Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support x64-glibc-217 #1361

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kaaax0815
Copy link

Closes #1331

Support installation of newer node version on older systems using unofficial builds

Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: 92dfd42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fnm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fnm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 2:26pm

@kaaax0815
Copy link
Author

kaaax0815 commented Jan 8, 2025

I see refactor opportunity here:

fnm/src/downloader.rs

Lines 49 to 57 in 4399644

#[cfg(windows)]
fn filename_for_version(version: &Version, arch: Arch, ext: &str) -> String {
format!(
"node-{node_ver}-win-{arch}.{ext}",
node_ver = &version,
arch = arch,
ext = ext,
)
}

why not support windows here

fnm/src/system_info.rs

Lines 1 to 10 in 4399644

#[cfg(target_os = "macos")]
pub fn platform_name() -> &'static str {
"darwin"
}
#[cfg(target_os = "linux")]
pub fn platform_name() -> &'static str {
"linux"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support x64-glibc-127
1 participant