This repository has been archived by the owner on Mar 1, 2022. It is now read-only.
Analyzer runner w/ push notifications - squashed #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->samples = ceil($secondsToAnalyze / $frequency); | ||
| } | ||
|
|
||
| public function analyze() |
There was a problem hiding this comment.
This method is duplicated between GraphAnalyzer and NumberAnalyzer - please refactor.
|
I'm trying to figure out from the code, but I'm not 100% sure: is this 100% compatible with dashoards WITHOUT access to VG Push Platform API? What I mean is: if I don't supply keys in my config, will whole functionality be disabled and dashboard will work same as before? |
|
@domeq: to enable analyzer another cli process must be started - it does not affect standard rtm behaviour |
|
should I also fix phpcs errors from different classes (outside the PR scope)? |
|
No, these are on me :) |
|
phpcs fixed in master (all but one) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.