Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(circleciconfig): extend the schema of the requires stanza #4242

Conversation

briceicle
Copy link
Contributor

This PR updates the schema of the requires key for CircleCI workflow jobs.

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @CircleCI-Public/developer-experience - if they write a comment saying "LGTM" then it will be merged.

@briceicle briceicle force-pushed the brice/circleci-flexible-requires branch from 8ae8569 to d12835a Compare November 28, 2024 16:28
Copy link
Contributor

@loderunner loderunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hyperupcall
Copy link
Member

Thanks

@hyperupcall hyperupcall merged commit fb54fad into SchemaStore:master Dec 5, 2024
3 of 4 checks passed
@hyperupcall
Copy link
Member

hyperupcall commented Dec 5, 2024

@loderunner Unfortunately review comments consistently error when attempting to use the bot, only regular comments seem to work. Found this to be tracked by OSS-Docs-Tools/code-owner-self-merge#35

migalons pushed a commit to migalons/schemastore that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants