Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use usernames as codeowners for venvironment schemas #4192

Conversation

raphael-grimm
Copy link
Contributor

(as suggested in #4190)

@github-actions github-actions bot added the ci ".github/**/*" folder is updated (auto-generated by labeler action) label Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@raphael-grimm
Copy link
Contributor Author

@hyperupcall seems to have the same / a similar issue with usernames.

Unknown owner on line 30: make sure @raphael-grimm exists and has write access to the repository
…t-* @vectorgrp/canoe-ci-tools @raphael-grimm @JoergSrj

Since I don't have write permissions on this repo I can't be codeowner

@hyperupcall
Copy link
Member

hyperupcall commented Nov 4, 2024

Thanks for the followup PR!.

For the error shown by GitHub, GitHub's CODEOWNER linter is giving a false positive (for our use case). Instead of giving managing code owners through GitHub directly, we use the code-owner-self-merge action because it's more flexible and customizable. That action itself parses the CODEOWNERS file, does the @mentions, and merges the PRs (when a "codeowner" replies @lgtm). So even if GitHub prints a linting error, you should still be able to use the bot/action fully. More info available about the bot is in CONTRIBUTING.md

@raphael-grimm
Copy link
Contributor Author

@hyperupcall ok, understood. Are there any changes i should do to this branch?

@hyperupcall hyperupcall merged commit d77c05d into SchemaStore:master Nov 7, 2024
4 checks passed
@hyperupcall
Copy link
Member

Nope, thank you

@raphael-grimm raphael-grimm deleted the usernames-as-codeowners-for-venvironment-schemas branch November 7, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci ".github/**/*" folder is updated (auto-generated by labeler action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants