-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resolve #1443] Add parameter type checking #1442
Merged
zaro0508
merged 11 commits into
Sceptre:master
from
alex-harvey-z3q:ah/ensure-params-poc
Feb 27, 2024
Merged
[Resolve #1443] Add parameter type checking #1442
zaro0508
merged 11 commits into
Sceptre:master
from
alex-harvey-z3q:ah/ensure-params-poc
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
alex-harvey-z3q
changed the title
Add a proof of concept for type checking
[Resolve #1443] Add parameter type checking
Feb 17, 2024
zaro0508
reviewed
Feb 19, 2024
zaro0508
approved these changes
Feb 20, 2024
alex-harvey-z3q
added a commit
to alex-harvey-z3q/sceptre
that referenced
this pull request
Jun 2, 2024
)" This reverts commit f3b7e51.
alex-harvey-z3q
added a commit
to alex-harvey-z3q/sceptre
that referenced
this pull request
Jun 2, 2024
…ceptre#1442)"" This reverts commit c5b8b0f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For historical reasons, Sceptre has never validated Stack config parameters that are passed in to CloudFormation stack parameters. Blocks that contain bools, ints etc give rise to confusing failures. For example:
Would lead to an error appearing like:
In more complicated examples it is often quite unclear what Parameter[0] means.
A feature here is added at the time of Stack instantiation to perform validation of the input stack parameters in a similar manner to how the ignore and obsolete settings were already being checked.
PR Checklist
[Resolve #issue-number]
.poetry run tox
) are passing.poetry run pre-commit run --all-files
).and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit