Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove classifiers #1438

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Conversation

zaro0508
Copy link
Contributor

@zaro0508 zaro0508 commented Feb 7, 2024

Removing classifiers in poetry.toml because poetry will auto generate the classifiers[1]

[1] https://python-poetry.org/docs/pyproject/#classifiers

Removing classifiers in poetry.toml because poetry will auto generate the classifiers[1]

[1] https://python-poetry.org/docs/pyproject/#classifiers
Copy link
Member

@tarkatronic tarkatronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the Environment classifier? I'm not certain that one can be auto-generated either.

@zaro0508
Copy link
Contributor Author

zaro0508 commented Feb 7, 2024

Should we remove the Environment classifier? I'm not certain that one can be auto-generated either.

hmm, the docs just has a general statement that it will auto generate classifiers. how do you know which ones it can and cannot auto generate?

@tarkatronic
Copy link
Member

Should we remove the Environment classifier? I'm not certain that one can be auto-generated either.

hmm, the docs just has a general statement that it will auto generate classifiers. how do you know which ones it can and cannot auto generate?

From my understanding of that statement, only the License and Programming Language :: Python :: <version> classifiers will be auto-generated.

@zaro0508
Copy link
Contributor Author

zaro0508 commented Feb 7, 2024

From my understanding of that statement, only the License and Programming Language :: Python :: <version> classifiers will be auto-generated.

ok, so how does poetry infer the license without the classifier? does it look in the root folder for a license file?

@zaro0508
Copy link
Contributor Author

zaro0508 commented Feb 8, 2024

i've fixed the classifier. take another look @tarkatronic ?

Copy link
Member

@tarkatronic tarkatronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zaro0508 zaro0508 merged commit 64fdbab into Sceptre:master Feb 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants