Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add integration test workflow #1430

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

zaro0508
Copy link
Contributor

Setup a workflow to trigger an integration test run from a review comment.

Integration tests take a long time to complete therefore it is typically only run as a final check before merging to the master branch.

The idea is to allow users to trigger an integration test run only after all other tests have passed AND a human review approval has been provided. Adding an /integration-tests string to a PR review will trigger the integration test run.

Setup a workflow to trigger an integration test run from a review comment.

Integration tests take a long time to complete therefore it is typically
only run as a final check before merging to the master branch.

The idea is to allow users to trigger an integration test run only after
all other tests have passed AND a human review approval has been provided.
Adding an `/integration-tests` string to a PR review will trigger the
integration test run.
Copy link
Member

@tarkatronic tarkatronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, this is cool!

@zaro0508 zaro0508 merged commit 1684c5e into Sceptre:master Feb 3, 2024
12 checks passed
@zaro0508
Copy link
Contributor Author

zaro0508 commented Feb 4, 2024

unfortunately this doesn't work because github action does not allow access to the github token when triggered from a PR. The workflow fails with.. "Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants