Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: GetJob, DeleteJob, ListJobsByPrefix #79

Closed
wants to merge 6 commits into from

Conversation

cicoyle
Copy link

@cicoyle cicoyle commented Jan 21, 2024

I would like to add the rest of the CRUD methods, such that a user can use this pkg to:

  • AddJob (already exists)
  • GetJob (new)
  • DeleteJob (new)
  • ListJobsByPrefix (new)

Not sure if there was a reason the GetJob, DeleteJob, ListJobsByPrefix weren't already added?

This PR closes this issue

Copy link

@leo-scalingo leo-scalingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cicoyle

Thanks for your contribution.

From what I understand, you're looking to make it more dynamic, our usage so far was to initialize all jobs at the beginning of a sofware.

It's ok to do so, but in this case, entries should by protected by a Mutex to prevent race conditions, can you handle that?

Thanks

@cicoyle
Copy link
Author

cicoyle commented Mar 15, 2024

Closing this PR since our needs went beyond the original intent of this library. We have forked this repo and significantly re-written it for our Distributed Scheduler needs, see here if curious :)

@cicoyle cicoyle closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cron Tests Failing Inquiry
2 participants