Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cron Tests Failing Inquiry #78

Open
cicoyle opened this issue Jan 21, 2024 · 1 comment
Open

Cron Tests Failing Inquiry #78

cicoyle opened this issue Jan 21, 2024 · 1 comment

Comments

@cicoyle
Copy link

cicoyle commented Jan 21, 2024

I am running the cron_test.go tests locally and all but 2 fail due to needing etcd running locally. This should be noted somewhere so users can run the tests locally.

Is there any plan to add a GH action to run the tests in CI to ensure they pass upon people opening PRs and making changes?

@cicoyle
Copy link
Author

cicoyle commented Jan 22, 2024

I must've had an etcd running previously and forgot. I got them all working.

Things to add to documentation in order to run tests locally:

  1. install etcd
  2. launch etcd locally: etcd --logger=zap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant