Added test case to show issue with export default #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to add the tests to |
jmcclell
force-pushed
the
export-default-testcase
branch
from
6db99bd
to
02257bf
Compare
Some pacakges such as pixi.js re-export 3rd party libraries under their
own namespace, e.g. @pixi/util does the following:
export { default as EventEmitter } from 'eventemitter3'
in order to provide the EventEmitter module from eventemitter3 under the
@pixi/util namespace.
The converter appears to ignore exports of this form and no module is
created. This breaks libraries that rely on this behavior such as Pixi.
jmcclell
force-pushed
the
export-default-testcase
branch
from
b363b44
to
2039cd5
Compare
steinybot
reviewed
Aug 1, 2024
| @@ -0,0 +1 @@ | |||
| export { default as Foo } from "foo"; | |||
There was a problem hiding this comment.
Did you mean to commit these? I'd probably keep a subset of the the real code for pixi-utils rather than creating a ficticious export-default package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some pacakges such as pixi.js re-export 3rd party libraries under their own namespace, e.g. @pixi/util does the following:
export { default as EventEmitter } from 'eventemitter3'
in order to provide the EventEmitter module from eventemitter3 under the @pixi/util namespace.
The converter appears to ignore exports of this form and no module is created. This breaks libraries that rely on this behavior such as Pixi.
NOTE: This test doesn't show any import failures or warnings, but the issue is that the module isn't generated in the output code as expected.