Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use loongarch save register $s0 $s1 $s2 #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use loongarch save register $s0 $s1 $s2 #16

wants to merge 1 commit into from

Conversation

loongson-zjl
Copy link

No description provided.

xen0n
xen0n reviewed Jun 29, 2021
View reviewed changes
Copy link

@xen0n xen0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your commit message has $s2 misspelled, please correct.

Still, concrete benchmark numbers would be great; the code compiles just fine on LoongArch so it's pointless unless you can definitely prove there's a performance win in doing this.

@loongson-zjl loongson-zjl changed the title Use loongarch save register $s0 $s1 $2 Use loongarch save register $s0 $s1 $s2 Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xen0n xen0n xen0n left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loongson-zjl @xen0n