Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix build #2

wants to merge 1 commit into from

Conversation

T-rvw
Copy link

@T-rvw T-rvw commented Sep 25, 2023

Adapt assimp build changes and fix errors from latest OpenMP in VS2022.
BTW, blog link seems invalid now.

@@ -56,7 +56,7 @@ void ProgModel::LoadOFF(std::string const & path) {
mMeshes.push_back(mesh);

#pragma omp parallel for
for (size_t i = 0; i < mMeshes.size(); ++i) {
for (int i = 0; i < mMeshes.size(); ++i) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error C3016: 'i': index variable in OpenMP 'for' statement must have signed integral type

@@ -87,7 +87,7 @@ void ProgModel::LoadProgModel(const std::string &path) {

// Once all models are loaded, ask them to build their mesh connectivity data structures.
#pragma omp parallel for
for (size_t i = 0; i < mMeshes.size(); ++i) {
for (int i = 0; i < mMeshes.size(); ++i) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant