RHBK support #17338

lhellebr · 2025-01-15T14:46:00Z

Make changes so RHSSO tests become parametrized and work for both RHSSO and RHBK, limit TemplateSync tests

Problem Statement

Solution

Related Issues

lhellebr · 2025-01-16T11:27:06Z

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_timeout_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_two_factor_login_using_hammer

lhellebr · 2025-01-16T11:28:04Z

PRT running test_rhsso_login_using_hammer that is newly parametrized, RHSSO and RHBK version. Also running two unparametrized tests to make sure the fixtures are backwards compatible.

lhellebr · 2025-01-16T11:32:21Z

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_timeout_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_two_factor_login_using_hammer

lhellebr · 2025-01-16T11:43:36Z

PRT waiting for config merge

Satellite-QE · 2025-01-16T13:09:21Z

PRT Result

Build Number: 9899
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_timeout_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_two_factor_login_using_hammer --external-logging
Test Result : ============ 1 passed, 466 warnings, 4 errors in 5207.71s (1:26:47) ============

ogajduse · 2025-01-22T10:27:52Z

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_timeout_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_two_factor_login_using_hammer

Satellite-QE · 2025-01-22T11:49:54Z

PRT Result

Build Number: 9953
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_timeout_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_two_factor_login_using_hammer --external-logging
Test Result : ================= 4 passed, 511 warnings in 4386.01s (1:13:06) =================

conf/rhbk.yaml.template

pytest_fixtures/component/satellite_auth.py

robottelo/hosts.py

lhellebr · 2025-01-28T15:40:43Z

@ogajduse comments addressed

ogajduse

Thank you for addressing my above review comments. I have left one minor comment.

robottelo/hosts.py

Satellite-QE · 2025-01-31T15:43:13Z

PRT Result

Build Number: 10028
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_timeout_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_two_factor_login_using_hammer tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates --external-logging
Test Result : ======= 2 failed, 8 passed, 672 warnings, 8 errors in 5723.00s (1:35:22) =======

lhellebr · 2025-02-03T15:09:58Z

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_timeout_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_two_factor_login_using_hammer tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates

Satellite-QE · 2025-02-03T16:41:31Z

PRT Result

Build Number: 10034
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_timeout_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_two_factor_login_using_hammer tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates --external-logging
Test Result : ================ 18 passed, 646 warnings in 5038.33s (1:23:58) =================

tests/foreman/destructive/test_ldapauthsource.py

Copilot

Copilot reviewed 5 out of 10 changed files in this pull request and generated 1 comment.

Files not reviewed (5)

conf/rhbk.yaml.template: Language not supported
pytest_fixtures/component/satellite_auth.py: Evaluated as low risk
tests/foreman/destructive/test_ldap_authentication.py: Evaluated as low risk
tests/foreman/destructive/test_ldapauthsource.py: Evaluated as low risk
tests/foreman/ui/test_templatesync.py: Evaluated as low risk

Comments suppressed due to low confidence (1)

robottelo/hosts.py:2567

The get_two_factor_token_rh_sso_url method should use an f-string for better readability and consistency.

return (f"https://{self.host_name}/auth/realms/" f"{self.realm}/protocol/openid-connect/")

robottelo/hosts.py

Make changes so RHSSO tests become parametrized and work for both RHSSO and RHBK

lhellebr · 2025-02-05T11:13:49Z

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_timeout_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_two_factor_login_using_hammer tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates

Satellite-QE · 2025-02-05T11:49:41Z

PRT Result

Build Number: 10067
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_timeout_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_two_factor_login_using_hammer tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates --external-logging
Test Result : =========== 14 passed, 157 warnings, 4 errors in 1640.40s (0:27:20) ============

lhellebr · 2025-02-05T12:05:23Z

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_timeout_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_two_factor_login_using_hammer tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates

Satellite-QE · 2025-02-05T13:36:28Z

PRT Result

Build Number: 10073
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_login_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_timeout_using_hammer tests/foreman/destructive/test_ldapauthsource.py::test_rhsso_two_factor_login_using_hammer tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_positive_export_all_templates_to_repo tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_dir_filtered tests/foreman/ui/test_templatesync.py::test_positive_import_templates --external-logging
Test Result : ================ 18 passed, 637 warnings in 5046.06s (1:24:06) =================

lhellebr added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Jan 15, 2025

lhellebr force-pushed the rhsso_to_rhbk branch from 0cf7cc1 to c8ac423 Compare January 16, 2025 11:26

lhellebr force-pushed the rhsso_to_rhbk branch from c8ac423 to 4a7da48 Compare January 16, 2025 11:31

lhellebr marked this pull request as ready for review January 16, 2025 11:32

lhellebr requested review from a team as code owners January 16, 2025 11:32

github-actions bot assigned lhellebr Jan 16, 2025

Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jan 16, 2025

Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jan 22, 2025

ogajduse reviewed Jan 22, 2025

View reviewed changes

conf/rhbk.yaml.template Outdated Show resolved Hide resolved

pytest_fixtures/component/satellite_auth.py Show resolved Hide resolved

robottelo/hosts.py Show resolved Hide resolved

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 28, 2025

lhellebr force-pushed the rhsso_to_rhbk branch 3 times, most recently from 8d9eb02 to bb9a399 Compare January 28, 2025 14:59

lhellebr requested a review from ogajduse January 28, 2025 15:40

ogajduse requested a review from Copilot January 28, 2025 17:39

ogajduse reviewed Jan 28, 2025

View reviewed changes

robottelo/hosts.py Outdated Show resolved Hide resolved

lhellebr force-pushed the rhsso_to_rhbk branch from bb9a399 to 88ef4e6 Compare January 29, 2025 17:05

Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jan 31, 2025

Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Feb 3, 2025

lhellebr requested a review from ogajduse February 3, 2025 17:10

ogajduse reviewed Feb 4, 2025

View reviewed changes

tests/foreman/destructive/test_ldapauthsource.py Show resolved Hide resolved

ogajduse requested review from Copilot and removed request for Copilot February 4, 2025 18:01

Copilot AI reviewed Feb 4, 2025

View reviewed changes

robottelo/hosts.py Outdated Show resolved Hide resolved

lhellebr added 3 commits February 5, 2025 12:06

RHBK support

a6e60ba

Make changes so RHSSO tests become parametrized and work for both RHSSO and RHBK

Refactor SSOHost and limit templatesync tests

d10bc64

Remove self.rhbk, it's not used

26142e9

lhellebr force-pushed the rhsso_to_rhbk branch from 228bf90 to 811fd4a Compare February 5, 2025 11:06

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 5, 2025

Replace removed .rhbk by type check

7c4c757

lhellebr force-pushed the rhsso_to_rhbk branch from 811fd4a to 7c4c757 Compare February 5, 2025 11:13

Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 5, 2025

ogajduse approved these changes Feb 5, 2025

View reviewed changes

Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Feb 5, 2025

ogajduse merged commit 1efa89c into SatelliteQE:master Feb 5, 2025
13 checks passed

This was referenced Feb 5, 2025

[Failed-AutoCherryPick] - RHBK support #17516

Open

[Failed-AutoCherryPick] - RHBK support #17517

Open

[Failed-AutoCherryPick] - RHBK support #17518

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RHBK support #17338

RHBK support #17338

lhellebr commented Jan 15, 2025 •

edited

Loading

lhellebr commented Jan 16, 2025

lhellebr commented Jan 16, 2025

lhellebr commented Jan 16, 2025

lhellebr commented Jan 16, 2025

Satellite-QE commented Jan 16, 2025

ogajduse commented Jan 22, 2025

Satellite-QE commented Jan 22, 2025

lhellebr commented Jan 28, 2025

ogajduse left a comment

Satellite-QE commented Jan 31, 2025

lhellebr commented Feb 3, 2025

Satellite-QE commented Feb 3, 2025

Copilot AI left a comment

lhellebr commented Feb 5, 2025

Satellite-QE commented Feb 5, 2025

lhellebr commented Feb 5, 2025

Satellite-QE commented Feb 5, 2025

RHBK support #17338

RHBK support #17338

Conversation

lhellebr commented Jan 15, 2025 • edited Loading

Problem Statement

Solution

Related Issues

lhellebr commented Jan 16, 2025

lhellebr commented Jan 16, 2025

lhellebr commented Jan 16, 2025

lhellebr commented Jan 16, 2025

Satellite-QE commented Jan 16, 2025

ogajduse commented Jan 22, 2025

Satellite-QE commented Jan 22, 2025

lhellebr commented Jan 28, 2025

ogajduse left a comment

Choose a reason for hiding this comment

Satellite-QE commented Jan 31, 2025

lhellebr commented Feb 3, 2025

Satellite-QE commented Feb 3, 2025

Copilot AI left a comment

Choose a reason for hiding this comment

lhellebr commented Feb 5, 2025

Satellite-QE commented Feb 5, 2025

lhellebr commented Feb 5, 2025

Satellite-QE commented Feb 5, 2025

lhellebr commented Jan 15, 2025 •

edited

Loading