Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHEL10 Clients coverage in Content, rhel7 & 8 hosts bumped #17003

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

damoore044
Copy link
Contributor

@damoore044 damoore044 commented Nov 26, 2024

Update RH repos for RHEL10 Beta, BaseOS, and Appstream
Migrate existing rhel 7 and 8 content hosts to rhel 9 and 10.
By parametrization of fixture rhel_contenthost, or by importing the newly added rhel10_contenthost

PRT

For cases using fixture rhel_contenthost
parametrized by pytest.marker.rhel_ver_match or rhel_ver_list

trigger: test-robottelo
pytest: tests/foreman/api cli ui/module.py -k 'rhel10' 

@damoore044 damoore044 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Nov 26, 2024
@damoore044 damoore044 self-assigned this Nov 26, 2024
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ -k 'rhel10' --ignore-glob='**/test_errata.py' --collect-only

@damoore044
Copy link
Contributor Author

damoore044 commented Nov 26, 2024

^ ignoring errata rhel10 cases for first collection,
as they've already been tested and merged in #16807

Works locally but fails for PRT, see below for proper CI exclusion comment

17:46:48  ============================= test session starts ==============================
17:46:48  platform linux -- Python 3.12.7, pytest-8.3.3, pluggy-1.5.0
    ...
17:47:20  collected 5460 items / 5412 deselected / 48 selected <<<

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ -k 'rhel10' --collect-only $(find tests/foreman/ -type f -name 'test_errata.py' -exec echo --ignore={} \;)

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/ -k 'rhel10' $(find tests/foreman/ -type f -name 'test_errata.py' -exec echo --ignore={} \;)
env:
     ROBOTTELO_content_host__rhel10__vm__workflow: 'deploy-template'
     ROBOTTELO_content_host__rhel10__vm__deploy_template_type: 'rhel'
     ROBOTTELO_content_host__rhel10__vm__deploy_custom_template_version: '10'

@damoore044
Copy link
Contributor Author

damoore044 commented Nov 26, 2024

^ foreman/API tests with rhel10 params, ignoring test_errata.py
Should be 9 new cases (rhel10) collected and executed

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/ -k 'rhel10' $(find tests/foreman/api/ -type f -name 'test_errata.py' -exec echo --ignore={} \;)
env:
     ROBOTTELO_content_host__rhel10__vm__workflow: 'deploy-template'
     ROBOTTELO_content_host__rhel10__vm__deploy_template_type: 'rhel'
     ROBOTTELO_content_host__rhel10__vm__deploy_custom_template_version: '10'

@damoore044 damoore044 changed the title RHEL10 Clients coverage in Content, some rhel8 content bumped to rhel9 RHEL10 Clients coverage in Content, some rhel7 and 8 content bumped to rhel9 and 10 Nov 26, 2024
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py -k 'rhel10' 
env:
     ROBOTTELO_content_host__rhel10__vm__workflow: 'deploy-template'
     ROBOTTELO_content_host__rhel10__vm__deploy_template_type: 'rhel'
     ROBOTTELO_content_host__rhel10__vm__deploy_custom_template_version: '10'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9471
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contenthost.py -k rhel10 --external-logging
Test Result : == 10 failed, 10 passed, 129 deselected, 1457 warnings in 6396.11s (1:46:36) ===

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Nov 27, 2024
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py
env:
     ROBOTTELO_content_host__rhel10__vm__workflow: 'deploy-template'
     ROBOTTELO_content_host__rhel10__vm__deploy_template_type: 'rhel'
     ROBOTTELO_content_host__rhel10__vm__deploy_custom_template_version: '10'

@damoore044
Copy link
Contributor Author

^ Full test of all cases api/test_errata.py , rhel10 and priors.
Due to significant changes to that module

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9490
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_errata.py --external-logging
Test Result : ========== 4 failed, 10 passed, 4437 warnings in 10620.88s (2:57:00) ===========

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_errata.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9554
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_errata.py --external-logging
Test Result : =========== 7 failed, 1279 warnings, 7 errors in 6489.17s (1:48:09) ============

@damoore044 damoore044 force-pushed the rhel10-cases branch 2 times, most recently from a16ae35 to 448d830 Compare December 17, 2024 16:36
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api -k 'rhel10'

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli -k 'rhel10'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9659
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli -k rhel10 --external-logging
Test Result : = 9 failed, 12 passed, 1938 deselected, 5353 warnings, 14 errors in 16245.78s (4:30:45) =

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api -k 'rhel10'

@damoore044 damoore044 changed the title RHEL10 Clients coverage in Content, some rhel7 and 8 content bumped to rhel9 and 10 RHEL10 Clients coverage in Content, rhel7 & 8 hosts bumped Jan 8, 2025
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9790
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api -k rhel10 --external-logging
Test Result : = 3 failed, 11 passed, 2322 deselected, 3890 warnings, 9 errors in 7672.85s (2:07:52) =

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api -k 'rhel10'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9801
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api -k rhel10 --external-logging
Test Result : == 3 failed, 20 passed, 2322 deselected, 5664 warnings in 11824.01s (3:17:04) ==

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api -k 'rhel10'

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments from just a quick glance.

@@ -67,6 +67,8 @@ def module_sync_kickstart_content(
rhel_ver = request.param['rhel_version']
if int(rhel_ver) <= 7:
repo_names.append(f'rhel{rhel_ver}')
elif rhel_ver == 10:
repo_names.append(f'rhel{rhel_ver}_bos_beta')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these be switched to the GA repos once RHEL 10 goes GA?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for now I've put this because the kickstart and some other repos
have been merged by others as rhel10_bos_beta

@@ -58,6 +58,12 @@ def module_rhel_contenthost(request):
with Broker(**host_conf(request), host_class=ContentHost) as host:
yield host

@pytest.fixture(params=[{'rhel_version': 6}])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since RHEL 6 is EOL even with extended maintenance, is it worth keeping a fixture for RHEL 6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup from initial glance looks like no tests using this rhel6_contenthost,
I'll make sure on the impact, but seems fine to drop

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsedmik @JacobCallahan thoughts on dropping fixture rhel6_contenthost in stream?

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9805
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api -k rhel10 --external-logging
Test Result : = 4 failed, 21 passed, 2319 deselected, 7607 warnings, 1 error in 23726.29s (6:35:26) =

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py

@damoore044 damoore044 marked this pull request as ready for review January 10, 2025 17:16
@damoore044 damoore044 requested review from a team as code owners January 10, 2025 17:16
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9819
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contenthost.py --external-logging
Test Result : = 3 failed, 9 passed, 1 deselected, 1027 warnings, 10 errors in 20731.91s (5:45:31) =

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants