-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHEL10 Clients coverage in Content, rhel7 & 8 hosts bumped #17003
base: master
Are you sure you want to change the base?
Conversation
trigger: test-robottelo |
^ ignoring errata rhel10 cases for first collection, Works locally but fails for PRT, see below for proper CI exclusion comment
|
|
|
^ foreman/API tests with rhel10 params, ignoring test_errata.py |
|
829ef70
to
a008694
Compare
|
PRT Result
|
a008694
to
2b76a7f
Compare
|
^ Full test of all cases |
2b76a7f
to
595f819
Compare
trigger: test-robottelo |
PRT Result
|
595f819
to
d26d767
Compare
trigger: test-robottelo |
PRT Result
|
a16ae35
to
448d830
Compare
trigger: test-robottelo |
trigger: test-robottelo |
PRT Result
|
448d830
to
3850055
Compare
trigger: test-robottelo |
PRT Result
|
3850055
to
ed29deb
Compare
trigger: test-robottelo |
ed29deb
to
8751a15
Compare
PRT Result
|
trigger: test-robottelo |
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments from just a quick glance.
@@ -67,6 +67,8 @@ def module_sync_kickstart_content( | |||
rhel_ver = request.param['rhel_version'] | |||
if int(rhel_ver) <= 7: | |||
repo_names.append(f'rhel{rhel_ver}') | |||
elif rhel_ver == 10: | |||
repo_names.append(f'rhel{rhel_ver}_bos_beta') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will these be switched to the GA repos once RHEL 10 goes GA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for now I've put this because the kickstart and some other repos
have been merged by others as rhel10_bos_beta
pytest_fixtures/core/contenthosts.py
Outdated
@@ -58,6 +58,12 @@ def module_rhel_contenthost(request): | |||
with Broker(**host_conf(request), host_class=ContentHost) as host: | |||
yield host | |||
|
|||
@pytest.fixture(params=[{'rhel_version': 6}]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since RHEL 6 is EOL even with extended maintenance, is it worth keeping a fixture for RHEL 6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup from initial glance looks like no tests using this rhel6_contenthost,
I'll make sure on the impact, but seems fine to drop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vsedmik @JacobCallahan thoughts on dropping fixture rhel6_contenthost
in stream?
PRT Result
|
trigger: test-robottelo |
8751a15
to
e554150
Compare
e554150
to
98842c0
Compare
PRT Result
|
Update RH repos for RHEL10 Beta, BaseOS, and Appstream
Migrate existing rhel 7 and 8 content hosts to rhel 9 and 10.
By parametrization of fixture
rhel_contenthost
, or by importing the newly addedrhel10_contenthost
PRT
For cases using fixture
rhel_contenthost
parametrized by
pytest.marker.rhel_ver_match
orrhel_ver_list