Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(identity): Local importing and exporting functionality #305

Merged
merged 11 commits into from
Aug 24, 2023

Conversation

dariusc93
Copy link
Contributor

@dariusc93 dariusc93 commented Aug 22, 2023

What this PR does 📖

  • Implements logic for local importing and exporting identity using mnemonic phrase
  • Use ShortId in place of slice for the short id
  • Split the initialization apart from creating and restoring (this will change again in the future)

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

  • This does not support remote exporting to another node at this time but will come later as this lays out the ground work for manual importing and exporting while internally, it may be done automatically, either at intervals or after each event.
  • Exporting does not include messages at this time. This will be done separately as this interface handles the identity, friends list, requests, block list, etc.
  • Does not export internal cache. This will be rebuilt after the initial exchanges when friends or users come online and push their identity to discovered peers or friends.

Additional comments 🎤

  • This PR will requires the knowledge of one own mnemonic phrase prior to importing. This can be obtain prior to creating the identity, from IdentityProfile::passphrase, or from tesseract if the configuration flag is set to save it there prior to creating the identity

@dariusc93 dariusc93 self-assigned this Aug 22, 2023
@dariusc93 dariusc93 marked this pull request as ready for review August 23, 2023 21:46
@dariusc93 dariusc93 merged commit a76197d into main Aug 24, 2023
1 check passed
@dariusc93 dariusc93 deleted the feat/import-export branch August 24, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant