feat(video): add video test tool #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
I evaluated using OpenCV for camera capture and I evaluated multiple video codecs. I settled on the AV1 codec published by the alliance for open media. It would probably be helpful to leave the test code for the other codecs in this repository for reference.
The downside is that on Linux, some extra packages are needed to makeedit: a cargo feature was added to ignore the other codecs by default.cargo buildwork (related to clang, libx264, libaom` and probably openh264).I'm submitting a PR now instead of after adding video to Blink to help keep the PR size small.
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤
related to #272