Fix Windows build from source, add Window usage note to readme, up version to 1.0.8 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevereiner
commented
Sep 19, 2024
stevereiner
commented
- All was needed to get building from source to work on Windows was to add encoding="utf-8" when open readme.md for the long description in setup.py
- Added Windows only usage note to readme.md: put freeze_support() in the user's main file to avoid an error
- Up the version to 1.0.8 for Windows support and re-enabling allowing python 3.12
In setup,py , added open readme.md with utf-8 encoding for setting the long description. That's all it took to be able to fix being able to build from source on windows
Update from from 1.0.7 to 1.08 (for windows support, and re-enable python 3.12)
Note the need to have freeze_support() in your main file on Windows only
Updated README.md note on use on Windows to indicate only main function needed, not also freeze_support. Also noted that llama index RelikPathExtractor / PropertyGraphIndex runs 8 times slower for me on Windows vs Linux
|
Seems to also get my change from today to Windows note for README.md to my last week change. |
llama-relik project not relik-llama
|
Going to redo this pull request without readme file changes, but with the fix to allow building from source, change version to 1.0.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.