Fix overflow error on windows, go back to allow python 3.12 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix overflow error on windows, issue SapienzaNLP#15
Should put back allowing python 3.12 that relik 1.0.7 prevents. Retesting on ubuntu with fresh python 3.12 install, relik 1.0.6 was fine. Issue SapienzaNLP#14 on linux was just messed up python 3,12 env. Issue SapienzaNLP#14 and SapienzaNLP#15 windows overflow on all python versions needs the csv.field_size_limit change.
|
Thank you for your contribution! The fix for the overflow error on Windows with Python 3.10, 3.11, and 3.12 looks great. I appreciate the detailed testing you did on both Windows and Ubuntu with the Python 3.12 environment. I’ll merge it now, and this will resolve the issues (#14 and #15). Thanks again for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix overflow error on windows seen with versions of python (3.10, 3.11, 3.12), issue #15
relik/retriever/indexers/document.py
csv.field_size_limit(sys.maxsize) changed to
csv.field_size_limit(min(sys.maxsize, 2147483646))
(only able to build from source on linux not windows, did test line in windows with python 3.12 cli interpreter)
Should put back allowing python 3.12 that relik 1.0.7 prevents.
Retesting on ubuntu with fresh python 3.12 install, relik 1.0.6 was fine (and build from source with python 3.12 was fine too)
Issue #14 on linux was just messed up python 3.12 env.
setup.py
python_requires=">=3.10,<3.12",
change back to:
python_requires=">=3.10",