Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding python dependencies #106

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Adding python dependencies #106

wants to merge 1 commit into from

Conversation

cofinoa
Copy link
Member

@cofinoa cofinoa commented Jan 9, 2024

@miturbide I have added the python dependencies as a conda environment file

I don't know if there is any dependency with specific versions, please review!!

@cofinoa
Copy link
Member Author

cofinoa commented Jan 9, 2024

@mfansler
Copy link

It would be better to instead create a dedicated environment (not r-reticulate) that provides only the software needed by the Python scripts in this package. Since r-reticulate is the default for the reticulate package, it is very much prone to arbitrary changes by the user.

I'd also suggest to more explicitly constrain versions in the YAML file. What matters most is (presumably) correctness and consistency of execution. Ideally, installing say v3.4.0 of this package should always result in mostly the same Python environment. Without versions in the YAML, someone today might end up with Python 3.11, but a year from now with Python 3.13. And it would be unpredictable whether such version-creep will lead to identical evaluation of the Python scripts. I recommend identifying an environment with more definite versions (e.g., major + minor). Whenever a change to those package versions happens, it should involve updating the version of the R package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants