Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactor the
GlowBorder
ViewModifier implementation. By using@ViewBuilder
and avoiding type erasure withAnyView
, we achieve a cleaner, more efficient implementation.Changes
AnyView
type erasure inGlowBorder
with a genericContent
parameter and@ViewBuilder
.applyShadow
function to be recursive without the need for type erasure, thereby preserving the view's type throughout the modification process.Benefits
AnyView
, the view hierarchy remains more streamlined, potentially improving rendering performance as SwiftUI can better optimize the view diffing.Content
and@ViewBuilder
ensures that the view types are preserved, leveraging Swift's type system for compile-time checks.