[onert/train] Register LayerScopeTensor to registry #14235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zetwhite
commented
Oct 18, 2024
| fn_seq->iterate([&](exec::train::ITrainableFunction &fn) { | ||
| register_tensors(op_idx, (&fn)->registerLayerScopeTensors()); | ||
| }); | ||
| } |
There was a problem hiding this comment.
I'll show log like this :
[ BackendContext ] register layerscope tensor for CategoricalCrossentropyLoss
[ BackendContext ] register layerscope tensor for Softmax
[ BackendContext ] register layerscope tensor for FullyConnected
[ BackendContext ] (idx: @8-0) registered
[ BackendContext ] (idx: @8-1) registered
[ BackendContext ] (idx: @8-2) registered
[ BackendContext ] register layerscope tensor for FullyConnected
[ BackendContext ] (idx: @7-0) registered
[ BackendContext ] (idx: @7-1) registered
[ BackendContext ] (idx: @7-2) registered
[ BackendContext ] (idx: @7-3) registered
[ BackendContext ] register layerscope tensor for Reshape
[ BackendContext ] register layerscope tensor for MaxPool2D
[ BackendContext ] (idx: @5-0) registered
[ BackendContext ] register layerscope tensor for Conv2D
[ BackendContext ] (idx: @4-0) registered
[ BackendContext ] (idx: @4-1) registered
[ BackendContext ] (idx: @4-2) registered
[ BackendContext ] (idx: @4-3) registered
[ BackendContext ] register layerscope tensor for Conv2D
[ BackendContext ] (idx: @3-0) registered
[ BackendContext ] (idx: @3-1) registered
[ BackendContext ] (idx: @3-2) registered
[ BackendContext ] (idx: @3-3) registered
zetwhite
removed
the
PR/ready for review
zetwhite
force-pushed
the
1018/tregister
branch
2 times, most recently
from
0f7de66
to
b3d7ee6
Compare
zetwhite
commented
Oct 18, 2024
| << std::endl; | ||
|
|
||
| fn_seq->iterate([&](exec::train::ITrainableFunction &fn) { | ||
| register_tensors(op_idx, (&fn)->registerLayerScopeTensors()); |
There was a problem hiding this comment.
(&fn)->registerLayerScopeTensors() call this functions and each layer will override this function.
ONE/runtime/onert/core/include/exec/train/ITrainableFunction.h
Lines 39 to 43 in 190b538
This PR registers LayerScopeTensor from each layer into tensor registry. ONE-DCO-1.0-Signed-off-by: seunghui youn <[email protected]> -------------------------------------- draft : Samsung#13486
zetwhite
force-pushed
the
1018/tregister
branch
from
b3d7ee6
to
06bbaee
Compare
|
@glistening Could you merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR registers LayerScopeTensor from each layer into tensor registry.
ONE-DCO-1.0-Signed-off-by: seunghui youn [email protected]
draft : #13486