1543 filter data fetched in recruitmentpositionoverviewpage #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itionoverviewpage
…tment overview page and fetches all recruitment application "types" correctly
Snorre98
commented
Oct 31, 2024
| @@ -1070,26 +1070,40 @@ def put(self, request: Request, pk: int) -> Response: | |||
|
|
|||
|
|
|||
| class RecruitmentApplicationForRecruitmentPositionView(ModelViewSet): | |||
| # TODO: refactor this in ISSUE #1575 | |||
There was a problem hiding this comment.
I #1575 skal RecruitmentStatusChoices hentes til frontend, så de definterte filter typene her må endres når det blir gjort.
There was a problem hiding this comment.
The only changes here are refactoring imports and adding prop + implementation of loading state conditional rendering/disable input.
| const url = | ||
| BACKEND_DOMAIN + | ||
| reverse({ | ||
| pattern: ROUTES.backend.samfundet__recruitment_applications_for_gang_detail, | ||
| urlParams: { pk: recruitmentPositionId }, | ||
| pattern: ROUTES.backend.samfundet__recruitment_applications_for_position_detail, |
There was a problem hiding this comment.
API call was fetching the wrong data
Comment on lines
+859
to
+867
|
|
||
| const params = filterType ? { filter_type: filterType } : {}; | ||
|
|
||
| const response = await axios.get<RecruitmentApplicationDto[]>(url, { | ||
| withCredentials: true, | ||
| params: params, | ||
| }); | ||
|
|
||
| return response.data; |
There was a problem hiding this comment.
Adds param for filtering in backend
There was a problem hiding this comment.
Refactored to only fetch data related to the position. Also implemented React Query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recruitment position overview page is taking a very long time to load when there is a lot of applications for a gang.
The long loading time stems from the fact that ALL applications for the gang is fetched ong the RecruitmentPositionOverviewPage.
This PR sets out to only fetch applications realted to the position, as well as implementing react query here.