Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MultiSelect component #1556

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Improve MultiSelect component #1556

merged 3 commits into from
Oct 29, 2024

Conversation

robines
Copy link
Member

@robines robines commented Oct 26, 2024

Changes:

  • Tweaked styling
  • Replace +/- with more understandable "Select all" and "Unselect all" buttons
    • Instead of hiding these buttons when one side is empty, they are instead just disabled, which is a more UX friendly approach
  • Set fixed height, which means no more layout shifts when selecting items.
  • Replace individual filtering with a single filter input, which filters both available and selected lists.
  • The "Select all" and "Unselect all" buttons now only move visible items
    • It's now trivial to select/unselect all items matching the filter, since you no longer have to individually click each item

@robines robines added the frontend Task related to frontend. label Oct 26, 2024
@robines robines self-assigned this Oct 26, 2024
Copy link
Contributor

@Snorre98 Snorre98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a32654-640488461

@robines robines merged commit e233ea5 into master Oct 29, 2024
5 checks passed
@robines robines deleted the robin/multiselect-styling branch October 29, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Task related to frontend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants