Fix some breadcrumbs and clean up other uses #1554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some breadcrumbs were broken due to not using the
reverse
function to add parameters to URL.Also simplified a lot of cases where the pathname from UIMatch wasn't being used. Using it lets us only have to declare the
path
for a route once. If we change the path one day, we won't have to update the breadcrumb too.Please note that Routes without a path (i.e
Outlet
) cannot use UIMatch.