Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some breadcrumbs and clean up other uses #1554

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

robines
Copy link
Member

@robines robines commented Oct 25, 2024

Some breadcrumbs were broken due to not using the reverse function to add parameters to URL.

Also simplified a lot of cases where the pathname from UIMatch wasn't being used. Using it lets us only have to declare the path for a route once. If we change the path one day, we won't have to update the breadcrumb too.

Please note that Routes without a path (i.e Outlet) cannot use UIMatch.

@robines robines added the frontend Task related to frontend. label Oct 25, 2024
@robines robines self-assigned this Oct 25, 2024
@robines robines added the bug Something isn't working. label Oct 25, 2024
@Snorre98
Copy link
Contributor

@robines lagde ikke Proffen et issue på dette? Mulig jeg husker feil og at det var et annet problem relatert til Breadcrumb. Hvis du husker, hadde det vært nice å close det om det løses her.

@robines
Copy link
Member Author

robines commented Oct 25, 2024

@Snorre98 Finner bare #1337 og det ser ikke ut til å handle om det denne PRen løser

@Snorre98
Copy link
Contributor

@Snorre98 Finner bare #1337 og det ser ikke ut til å handle om det denne PRen løser

Ah, var noe med t ja. Merge i vei for min del. Du er Breadcrumb eksperten

@robines robines enabled auto-merge (squash) October 25, 2024 18:04
@robines robines merged commit a5f30c1 into master Oct 25, 2024
5 checks passed
@robines robines deleted the robin/fix-various-breadcrumbs branch October 25, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. frontend Task related to frontend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants