Clean Input component & create NumberInput #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robines
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the way the Input component has evolved, it's not possible to use for file inputs. Nor is it possible to access the event object, which isn't great.
Converting values shouldn't be the concern of this component. It should be as simple as possible. For converting, wrapper components should be used. I've therefore created a NumberInput component, which should be easy to use.
Internally, the NumberInput component uses a
textinput, meaning we lose the browser-specific stepper buttons. This isn't really a big deal, we can add custom ones later if we wish.This PR also fixes RecruitmentFormAdminPage by fixing the
max_applicationsschema field and by using the new NumberInput component.