-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helper method to allow easier creation of AudioSources #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a 100% sure if we are going in the right direction with this helper method but I would like to see it merged until we find a better solution.
Please update the examples to use this helper method as well, and if you update the spatial example you will see there is a bit more work to be done :)
.gitignore
Outdated
@@ -6,3 +6,4 @@ assets/ | |||
*.so.* | |||
demo_project/ | |||
Cargo.lock | |||
.vscode/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I agree with this, but iirc @Salzian had some reservations about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add both like in the Bevy repo:
/.idea
/.vscode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a problem with it, but id love to see the conversation with @Salzian if its public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.vscode
and .idea
sometimes serve valuable metadata about the repository between developers. They usually have their own nested .gitignore
to only share the important bits. So feel free to check in the .vscode
folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna undo the changes, feels out of scope for the PR.
Closing for now until we have a better asset management system. |
With the current state of things, this is a simple way to spawn an AudioSource component:
With my proposed helper method, it would look more like this:
I have some questions, but I will leave them as inline comments for further discussion (I never tried doing that before so we shall see how it goes).