Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Python 3.12 #49

Merged
merged 14 commits into from
Nov 29, 2023
Merged

Update to Python 3.12 #49

merged 14 commits into from
Nov 29, 2023

Conversation

douglatornell
Copy link
Member

@douglatornell douglatornell commented Oct 16, 2023

  • Add Python 3.12 to GHA pytest-with-coverage workflow so that we can use the workflow to test whether all the packages SalishSeaCmd depends on have been updated to support Python 3.12.
  • Add workflow_dispatch trigger to GHA pytest-with-coverage workflow to enable workflow to be triggered from
    GitHub CLI, browser or via API
  • Drop Python 3.10 from GHA pytest-with-coverage workflow
  • Change pyproject.toml project.requires-python to >=3.11
  • Change conda environment descriptions to use Python 3.12
    • environment-dev.yaml
    • environment-hpc.yaml
    • environment-rtd.yaml
  • Change sphinx-linkcheck workflow to Python 3.12
  • Change pkg dev doc & README to Python 3.12 for package development

This lets us use the workflow to test whether all the packages NEMO-Cmd depends
on have been updated to support Python 3.12.
@douglatornell douglatornell added the maintenance Package or repo maintenance label Oct 16, 2023
@douglatornell douglatornell added this to the v23.1 milestone Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7fc3398) 95.22% compared to head (7249167) 95.21%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   95.22%   95.21%   -0.01%     
==========================================
  Files          10       10              
  Lines        1298     1296       -2     
  Branches      240      237       -3     
==========================================
- Hits         1236     1234       -2     
  Misses         58       58              
  Partials        4        4              
Flag Coverage Δ
unittests 95.21% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

douglatornell and others added 13 commits October 16, 2023 10:42
Enables workflow to be triggered from GitHub CLI, browser, or via API.

This is primarily to allow the workflow to be run via
    gh workflow run pytest-with-coverage --ref py312
during the conda-forge Python 3.12 migration to test if the environment is
solvable yet.
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.17 to 1.26.18.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.17...1.26.18)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pip](https://github.com/pypa/pip) from 23.1 to 23.3.
- [Changelog](https://github.com/pypa/pip/blob/main/NEWS.rst)
- [Commits](pypa/pip@23.1...23.3)

---
updated-dependencies:
- dependency-name: pip
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update pkgs & versions used in recent dev env

* pre-commit autoupdate

* Add Software_Collection/ARC_2023 module load

This may only be necessary for the testing period prior to the 31-Oct-2023
scheduler change-over.

* Drop python & py-setuptools module loads

They are no longer required because the SalishSeaCmd package is installed in
a conda environment that provides its dependencies, but via the --user scheme
that makes it available in the job script.

* Change to sbatch directives on sockeye cluster

* Drop Software_Collection/ARC_2023 module load

It was only necessary during the pre-transition testing period on sockeye.
Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.5 to 41.0.6.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@41.0.5...41.0.6)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
They are now just outdated maintenance overhead.
The Python version used in the 'sphinx-linkcheck.yaml' GitHub actions
workflow has been updated from '3.11' to '3.12'. This change aligns with the
recent migration to Python 3.12 for development.
@douglatornell douglatornell merged commit 4fc466b into main Nov 29, 2023
8 checks passed
@douglatornell douglatornell deleted the py312 branch November 29, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package or repo maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant