fix for 0 length txt parsing issue

fflewddur#14
Sagebits · Apr 22, 2020 · 9a999d4 · 9a999d4
1 parent 08d9b9f
commit 9a999d4
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/src/main/java/net/straylightlabs/hola/dns/Record.java b/src/main/java/net/straylightlabs/hola/dns/Record.java
@@ -138,13 +138,15 @@ private static String readLabel(ByteBuffer buffer, int length) {
 
     public static List<String> readStringsFromBuffer(ByteBuffer buffer, int length) {
         List<String> strings = new ArrayList<>();
-        int bytesRead = 0;
-        do {
-            int stringLength = buffer.get() & 0xFF;
-            String label = readLabel(buffer, stringLength);
-            bytesRead += label.length() + 1;
-            strings.add(label);
-        } while (bytesRead < length);
+        if (length > 0) {
+            int bytesRead = 0;
+            do {
+                int stringLength = buffer.get() & 0xFF;
+                String label = readLabel(buffer, stringLength);
+                bytesRead += label.length() + 1;
+                strings.add(label);
+            } while (bytesRead < length);
+        }
         return strings;
     }