-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYNPY-1544] Synapse Agent OOP Model #1152
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
@BWMac A bunch of tests seem to be failing with:
Since the integration tests run against the DEV Instance of Synapse, does this agent need to be created there, and tests updated with this config? |
@BryanFauble Ah yes the agent will need to be registered in Synapse Dev. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome changes! This all looks good to me.
When all the tests are passing we can move forward on merging the changes.
Description:
This PR is the implementation of an OOP model for interacting with the new Synapse Agent API endpoints. The design for the model implementation can be found in Confluence.
The core implementation includes (from "bottom to top"):
synapseclient.api.agent_services
:synapseclient.models.AgentPrompt
:AgentSession
class and is not intended to be used directly.AsynchronousCommunicator
Mixin which includes reusable logic for starting an async job, waiting for it to complete, and returning the response.synapseclient.models.AgentSession
:AgentSession
logic is used in theAgent
class, and we will generally recommend that users utilize theAgent
class as the primary interface.synapseclient.models.Agent
:start_session
or implicitly by just callingprompt
) becomes the default for prompting, but examples for conducting more than one session at a time can be found in the POC script and class docstring.Notes:
Experimental
section of the documentation, breaking up each model into it's own markdown script which makes maintaining the docs for OOP models a little easier.