Merge pull request #537 from zimingd/SYNPY-706

fixed attrubute error for syn.username when not logged in (SYNPY-706)
Sage-Bionetworks · May 7, 2018 · 3f9e4df · 3f9e4df
2 parents e1f2576 + 4d539e5
commit 3f9e4df
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/synapseclient/client.py b/synapseclient/client.py
@@ -242,7 +242,7 @@ def debug(self, value):
 
     @property
     def username(self): #for backwards compatability when username was a part of the Synapse object and not in credentials
-        return self.credentials.username
+        return self.credentials.username if self.credentials is not None else None
 
 
     def getConfigFile(self, configPath):

diff --git a/tests/unit/unit_test_client.py b/tests/unit/unit_test_client.py
@@ -375,4 +375,9 @@ def test_input_is_SchemaBase(self):
             schema = EntityViewSchema(parentId="syn123")
             results = list(syn.getColumns(schema))
             assert_equal(get_table_colums_results, results)
-            mock_get_table_coulmns.assert_called_with(schema)
+            mock_get_table_coulmns.assert_called_with(schema)
+
+def test_username_property__credentials_is_None():
+    syn.credentials = None
+    assert_is_none(syn.username)
+