Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORTALS-3253 #1525

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

PORTALS-3253 #1525

wants to merge 16 commits into from

Conversation

nickgros
Copy link
Collaborator

Remove usages of react-bootstrap

Remove usage of react-bootstrap in DataAccessRequestAccessorsEditor.tsx
Remove usage of react-bootstrap in ElementWithTooltip and related files. Replace ElementWithTooltip tooltip-only usage with MUI Tooltip.
Remove usage of react-bootstrap in FacetNavPanel and EnumFacetFilterDropdown
Remove usage of react-bootstrap in portals NavBar
Remove usage of react-bootstrap in AccountSettings
Remove usage of react-bootstrap in EmailConfirmationPage
Remove usage of react-bootstrap in SynapseNavDrawer
Remove usage of react-bootstrap in AccessApprovalsTable and AccessRequestSubmissionTable
Remove usage of react-bootstrap's Table in DownloadListTable.tsx

- Refactored the DownloadListTable to use a 'Show More' button instead of infinite scroll. I did this because this table's height is not constrained, so it would take a long time to reach the page footer if the list was very long.
- Refactored the DownloadListTable to use useMutation for removing items, and added a loading state based on the pending mutation status
- Left a note to virtualize the table as a performance improvement
- Added pinned column styles to shared TanStack table UI components
- Added ability to add a custom class name to a table row in shared TanStack table UI components
- Fixed incorrect query key for download cart infinite query
Remove usage of react-bootstrap in EntityFinderVersionCell
Remove usage of react-bootstrap in DiscussionThread
Remove usage of react-bootstrap in ForumThreadEditor
Remove usage of react-bootstrap in DatasetEditorVersionCell
Remove usage of react-bootstrap in EvaluationEditor
Remove usage of react-bootstrap in EvaluationCard
Remove usage of react-bootstrap in EvaluationRoundEditorDropdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant