-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PORTALS-3253 #1525
Draft
nickgros
wants to merge
16
commits into
Sage-Bionetworks:main
Choose a base branch
from
nickgros:PORTALS-3253b
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
PORTALS-3253 #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove usage of react-bootstrap in DataAccessRequestAccessorsEditor.tsx
Remove usage of react-bootstrap in ElementWithTooltip and related files. Replace ElementWithTooltip tooltip-only usage with MUI Tooltip.
Remove usage of react-bootstrap in FacetNavPanel and EnumFacetFilterDropdown
Remove usage of react-bootstrap in portals NavBar
Remove usage of react-bootstrap in AccountSettings
Remove usage of react-bootstrap in EmailConfirmationPage
Remove usage of react-bootstrap in SynapseNavDrawer
Remove usage of react-bootstrap in AccessApprovalsTable and AccessRequestSubmissionTable
Remove usage of react-bootstrap's Table in DownloadListTable.tsx - Refactored the DownloadListTable to use a 'Show More' button instead of infinite scroll. I did this because this table's height is not constrained, so it would take a long time to reach the page footer if the list was very long. - Refactored the DownloadListTable to use useMutation for removing items, and added a loading state based on the pending mutation status - Left a note to virtualize the table as a performance improvement - Added pinned column styles to shared TanStack table UI components - Added ability to add a custom class name to a table row in shared TanStack table UI components - Fixed incorrect query key for download cart infinite query
Remove usage of react-bootstrap in EntityFinderVersionCell
Remove usage of react-bootstrap in DiscussionThread
Remove usage of react-bootstrap in ForumThreadEditor
Remove usage of react-bootstrap in DatasetEditorVersionCell
Remove usage of react-bootstrap in EvaluationEditor
Remove usage of react-bootstrap in EvaluationCard
Remove usage of react-bootstrap in EvaluationRoundEditorDropdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usages of react-bootstrap