Address cfn-lint findings

Address E3009:, mode minimum length is 6 characters Ignore E3012 for PyPlate Address W3687: ['FromPort', 'ToPort'] are ignored when using 'IpProtocol' value '-1' Ignore W6001: The output value is an import from another output
Sage-Bionetworks · Dec 4, 2024 · e7b191b · e7b191b
1 parent b6ff6fe
commit e7b191b
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 12 deletions.
diff --git a/templates/batch/sc-batch-fargate.yaml b/templates/batch/sc-batch-fargate.yaml
@@ -206,6 +206,7 @@ Resources:
         config:
           ignore_checks:  # Ignore cfn-lint errors for PyPlate.
             - E3002
+            - E3012
     Type: AWS::Batch::JobDefinition
     Properties:
       Type: container

diff --git a/templates/ec2/sc-ec2-linux-docker-notebook.yaml b/templates/ec2/sc-ec2-linux-docker-notebook.yaml
@@ -5,6 +5,7 @@ Metadata:
     config:
       ignore_checks:
         - E7001
+        - W6001
   AWS::CloudFormation::Interface:
     ParameterGroups:
       - Label:
@@ -155,8 +156,6 @@ Resources:
         'Fn::FindInMap': [AccountToImportParams, !Ref "AWS::AccountId", VPCId]
       SecurityGroupIngress:
         - CidrIp: "10.50.0.0/16"
-          FromPort: -1
-          ToPort: -1
           IpProtocol: "-1"
 
   InstanceProfile:
@@ -274,7 +273,7 @@ Resources:
           files:
             /opt/sage/bin/make_env_vars_file.sh:
               source: "https://raw.githubusercontent.com/Sage-Bionetworks/service-catalog-utils/v2.0.3/linux/opt/sage/bin/make_env_vars_file.sh"
-              mode: "00744"
+              mode: "000744"
               owner: "root"
               group: "root"
           commands:

diff --git a/templates/ec2/sc-ec2-linux-docker.yaml b/templates/ec2/sc-ec2-linux-docker.yaml
@@ -86,8 +86,6 @@ Resources:
         'Fn::FindInMap': [AccountToImportParams, !Ref "AWS::AccountId", VPCId]
       SecurityGroupIngress:
         - CidrIp: "10.50.0.0/16"
-          FromPort: -1
-          ToPort: -1
           IpProtocol: "-1"
   InstanceRole:
     Type: AWS::IAM::Role
@@ -176,7 +174,7 @@ Resources:
           files:
             /opt/sage/bin/make_env_vars_file.sh:
               source: "https://raw.githubusercontent.com/Sage-Bionetworks/service-catalog-utils/v2.1.0/linux/opt/sage/bin/make_env_vars_file.sh"
-              mode: "00744"
+              mode: "000744"
               owner: "root"
               group: "root"
           commands:

diff --git a/templates/ec2/sc-ec2-windows-jumpcloud.yaml b/templates/ec2/sc-ec2-windows-jumpcloud.yaml
@@ -114,7 +114,7 @@ Resources:
           files:
             'c:\\scripts\\install-chocolatey.ps1':
               source: "https://chocolatey.org/install.ps1"
-              mode: "0664"
+              mode: "000664"
           commands:
             01_install_nuget:
               command: 'Powershell.exe Install-PackageProvider -Name NuGet -Force'
@@ -133,7 +133,7 @@ Resources:
           files:
             'c:\\scripts\\set_env_vars_file.ps1':
               source: "https://raw.githubusercontent.com/Sage-Bionetworks/infra-utils/v1.0.9/aws/set_env_vars_file.ps1"
-              mode: "0664"
+              mode: "000664"
           commands:
             01_set_env_vars:
               command: !Join
@@ -145,10 +145,10 @@ Resources:
           files:
             'c:\scripts\install-ms-vc.ps1':
               source: "https://raw.githubusercontent.com/Sage-Bionetworks/infra-utils/v1.0.8/aws/install-ms-vc.ps1"
-              mode: "0664"
+              mode: "000664"
             'c:\\scripts\\install-jc-agent.ps1':
               source: "https://raw.githubusercontent.com/TheJumpCloud/support/master/scripts/windows/InstallWindowsAgent.ps1"
-              mode: "0664"
+              mode: "000664"
           commands:
             01_install_ms_vc:
               command: !Join
@@ -220,8 +220,6 @@ Resources:
         'Fn::FindInMap': [AccountToImportParams, !Ref "AWS::AccountId", VPCId]
       SecurityGroupIngress:
         - CidrIp: "10.50.0.0/16"
-          FromPort: -1
-          ToPort: -1
           IpProtocol: "-1"
 Outputs:
   WindowsInstancePrivateIpAddress:

diff --git a/templates/s3/sc-s3-synapse-ra.yaml b/templates/s3/sc-s3-synapse-ra.yaml
@@ -84,6 +84,7 @@ Resources:
         config:
           ignore_checks:
             - E3001
+            - E3006
     Properties:
       Target:
         Bucket: !Ref S3Bucket
-Original file line number
+Diff line change
@@ Expand Up / @@ -84,6 +84,7 @@ Resources: @@
             config:
               ignore_checks:
                 - E3001
+                - E3006
         Properties:
           Target:
             Bucket: !Ref S3Bucket
@@ Expand Down @@