-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stunnel container image #2110
Conversation
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-2110 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2110/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2110 Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-2110/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for 7: home:defolos:BCI:Staging:SLE-15-SP7:7-2110 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.7 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2110/ tox -- -n auto The following images can be pulled from the staging project:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline comments
custom_end=f"""COPY entrypoint.sh /usr/local/bin/ | ||
COPY stunnel.conf /etc/stunnel/stunnel.conf | ||
{DOCKERFILE_RUN} chmod 0755 /usr/local/bin/entrypoint.sh; \ | ||
chown --recursive stunnel /etc/stunnel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this just be on the stunnel.conf
file rather than the directory as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think it would be better if the stunnel
user owns the whole directory. The entrypoint will write settings into /etc/stunnel/conf.d/
, so it makes imho sense for the directory to be owned by the stunnel user. We could resort to just the conf.d
subdir, but I see little benefit in that (and a lot of potential inconveniences).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like directories being owned by a service user as that allows that service user to modify permissions. probably not a big concern here but in general a owner=root,group=servicegroup,mod 0750 or so makes more sense to me. anyhow not a blocking issue.
https://jira.suse.com/browse/PED-11085 Co-authored-by: Dmitri Popov <[email protected]>
https://jira.suse.com/browse/PED-11085