Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stunnel container image #2110

Merged
merged 1 commit into from
Jan 17, 2025
Merged

add stunnel container image #2110

merged 1 commit into from
Jan 17, 2025

Conversation

dcermak
Copy link
Collaborator

@dcermak dcermak commented Dec 3, 2024

dcermak pushed a commit that referenced this pull request Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-2110
Changes pushed to branch 6-2110 as commit d614d321ef43df241da3e32abee4110efa442fd5
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2110 for x86_64: current state: published
Build results:

package name status build log
stunnel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2110 for aarch64: current state: published
Build results:

package name status build log
stunnel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2110 for s390x: current state: published
Build results:

package name status build log
stunnel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2110 for ppc64le: current state: published
Build results:

package name status build log
stunnel-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2110 for x86_64: current state: published
Build results:

package name status build log
stunnel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2110 for aarch64: current state: published
Build results:

package name status build log
stunnel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2110 for s390x: current state: published
Build results:

package name status build log
stunnel-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2110 for ppc64le: current state: published
Build results:

package name status build log
stunnel-image ⛔ excluded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2110/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2110/containerfile/containers/stunnel:latest

dcermak pushed a commit that referenced this pull request Dec 3, 2024
dcermak pushed a commit that referenced this pull request Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2110
Changes pushed to branch Tumbleweed-2110 as commit 12fa36c1ae8a760454392720fde5829fa5ff8e92
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2110 for x86_64: current state: published
Build results:

package name status build log
stunnel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2110 for aarch64: current state: published
Build results:

package name status build log
stunnel-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2110 for x86_64: current state: published
Build results:

package name status build log
stunnel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2110 for aarch64: current state: published
Build results:

package name status build log
stunnel-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-2110/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-2110/containerfile/opensuse/stunnel:latest

Copy link

github-actions bot commented Dec 3, 2024

Created a staging project on OBS for 7: home:defolos:BCI:Staging:SLE-15-SP7:7-2110
Changes pushed to branch 7-2110 as commit e4dc356918576019f5a39ad662e44765063dccb3
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2110 for x86_64: current state: published
Build results:

package name status build log
stunnel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2110 for aarch64: current state: published
Build results:

package name status build log
stunnel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2110 for s390x: current state: published
Build results:

package name status build log
stunnel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2110 for ppc64le: current state: published
Build results:

package name status build log
stunnel-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2110 for x86_64: current state: published
Build results:

package name status build log
stunnel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2110 for aarch64: current state: published
Build results:

package name status build log
stunnel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2110 for s390x: current state: published
Build results:

package name status build log
stunnel-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2110 for ppc64le: current state: published
Build results:

package name status build log
stunnel-image ⛔ excluded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.7 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2110/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2110/containerfile/containers/stunnel:5

dcermak pushed a commit that referenced this pull request Dec 4, 2024
dcermak pushed a commit that referenced this pull request Dec 4, 2024
dcermak pushed a commit that referenced this pull request Dec 4, 2024
dcermak pushed a commit that referenced this pull request Dec 4, 2024
dcermak pushed a commit that referenced this pull request Dec 4, 2024
dcermak pushed a commit that referenced this pull request Dec 4, 2024
dcermak pushed a commit that referenced this pull request Dec 4, 2024
dcermak pushed a commit that referenced this pull request Dec 4, 2024
dcermak pushed a commit that referenced this pull request Dec 4, 2024
dcermak pushed a commit that referenced this pull request Dec 5, 2024
dcermak pushed a commit that referenced this pull request Dec 5, 2024
dcermak pushed a commit that referenced this pull request Dec 5, 2024
dcermak pushed a commit that referenced this pull request Dec 5, 2024
dcermak pushed a commit that referenced this pull request Dec 5, 2024
dcermak pushed a commit that referenced this pull request Dec 5, 2024
dcermak pushed a commit that referenced this pull request Dec 5, 2024
dcermak pushed a commit that referenced this pull request Dec 5, 2024
dcermak pushed a commit that referenced this pull request Dec 5, 2024
@dcermak dcermak marked this pull request as ready for review December 5, 2024 15:24
@dcermak dcermak requested a review from dmpop December 5, 2024 15:24
src/bci_build/package/stunnel/README.md.j2 Outdated Show resolved Hide resolved
src/bci_build/package/stunnel/README.md.j2 Outdated Show resolved Hide resolved
src/bci_build/package/stunnel/README.md.j2 Outdated Show resolved Hide resolved
src/bci_build/package/stunnel/README.md.j2 Outdated Show resolved Hide resolved
src/bci_build/package/stunnel/README.md.j2 Outdated Show resolved Hide resolved
src/bci_build/package/stunnel/README.md.j2 Outdated Show resolved Hide resolved
src/bci_build/package/stunnel/README.md.j2 Outdated Show resolved Hide resolved
src/bci_build/package/stunnel/README.md.j2 Outdated Show resolved Hide resolved
src/bci_build/package/stunnel/README.md.j2 Outdated Show resolved Hide resolved
src/bci_build/package/stunnel/README.md.j2 Outdated Show resolved Hide resolved
dcermak pushed a commit that referenced this pull request Dec 6, 2024
dcermak pushed a commit that referenced this pull request Dec 6, 2024
dcermak pushed a commit that referenced this pull request Dec 6, 2024
dcermak pushed a commit that referenced this pull request Dec 6, 2024
dcermak pushed a commit that referenced this pull request Dec 6, 2024
dcermak pushed a commit that referenced this pull request Dec 6, 2024
Copy link
Member

@dirkmueller dirkmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments

@dcermak dcermak changed the title WIP: add stunnel container image add stunnel container image Jan 16, 2025
dcermak pushed a commit that referenced this pull request Jan 16, 2025
dcermak pushed a commit that referenced this pull request Jan 16, 2025
dcermak pushed a commit that referenced this pull request Jan 16, 2025
@dcermak dcermak requested a review from dirkmueller January 16, 2025 14:04
custom_end=f"""COPY entrypoint.sh /usr/local/bin/
COPY stunnel.conf /etc/stunnel/stunnel.conf
{DOCKERFILE_RUN} chmod 0755 /usr/local/bin/entrypoint.sh; \
chown --recursive stunnel /etc/stunnel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this just be on the stunnel.conf file rather than the directory as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think it would be better if the stunnel user owns the whole directory. The entrypoint will write settings into /etc/stunnel/conf.d/, so it makes imho sense for the directory to be owned by the stunnel user. We could resort to just the conf.d subdir, but I see little benefit in that (and a lot of potential inconveniences).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like directories being owned by a service user as that allows that service user to modify permissions. probably not a big concern here but in general a owner=root,group=servicegroup,mod 0750 or so makes more sense to me. anyhow not a blocking issue.

dcermak pushed a commit that referenced this pull request Jan 17, 2025
dcermak pushed a commit that referenced this pull request Jan 17, 2025
dcermak pushed a commit that referenced this pull request Jan 17, 2025
@dirkmueller dirkmueller merged commit d411741 into main Jan 17, 2025
8 checks passed
@dirkmueller dirkmueller deleted the stunnel branch January 17, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants