PLAYNEXT-1192 - Improve satellite radios discoverability #523
+58
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to improve discoverability, it was decided to add the Swiss Satellite Radios to the tab bar of radios in the audio tab.
However, those tabs should act only as buttons, opening modally the media player with the right radio, since there is no associated page.
Demo of the feature in action:
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2024-11-05.at.17.26.33.mp4
Changes Made
This implementation required me to jump a lot of hoops, and if this wasn't supposed to be a temporary solution, I would find another way to do it.
The main difficulty resides in the fact that Swiss Satellite Radios have no page associated, so the tabs should never be selected and act as buttons instead, but the TabMan component (recently introduced by yours truly) is supposed to work with a 1:1 mapping between a view controller and tab bar item.
Checklist