Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYNEXT-1192 - Improve satellite radios discoverability #523

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mutaben
Copy link
Contributor

@mutaben mutaben commented Nov 5, 2024

Description

In order to improve discoverability, it was decided to add the Swiss Satellite Radios to the tab bar of radios in the audio tab.

However, those tabs should act only as buttons, opening modally the media player with the right radio, since there is no associated page.

Demo of the feature in action:

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2024-11-05.at.17.26.33.mp4

Changes Made

This implementation required me to jump a lot of hoops, and if this wasn't supposed to be a temporary solution, I would find another way to do it.

The main difficulty resides in the fact that Swiss Satellite Radios have no page associated, so the tabs should never be selected and act as buttons instead, but the TabMan component (recently introduced by yours truly) is supposed to work with a 1:1 mapping between a view controller and tab bar item.

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@mutaben mutaben added the improvement Feature or update (issue and PR) - release notes section label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants