Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep player alive enough in background to play next content #228

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Application/Sources/Application/AppDelegate.m
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
NSAssert(NSClassFromString(@"ASIdentifierManager") == Nil, @"No implicit AdSupport.framework dependency must be found");

[AVAudioSession.sharedInstance setCategory:AVAudioSessionCategoryPlayback error:NULL];
[RemoteCommandCenter activateRatingCommand];

PlayApplicationRunOnce(^(void (^completionHandler)(BOOL success)) {
[PlayFirebaseConfiguration clearFirebaseConfigurationCache];
Expand Down
19 changes: 19 additions & 0 deletions Application/Sources/Helpers/RemoteCommandCenter.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
//
// Copyright (c) SRG SSR. All rights reserved.
//
// License information is available from the LICENSE file.
//

import Foundation
import MediaPlayer

// Magic subscription handler to presumably make iOS keep the player alive so we can continuously play audio in the background.
final class RemoteCommandCenter: NSObject {
@objc static func activateRatingCommand() {
MPRemoteCommandCenter.shared().ratingCommand.addTarget(self, action: #selector(Self.doNothing))
}

@objc private static func doNothing() -> MPRemoteCommandHandlerStatus {
.success
}
}
12 changes: 12 additions & 0 deletions PlaySRG.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@
04D5F926286C4542000A5A4E /* Recommendation.swift in Sources */ = {isa = PBXBuildFile; fileRef = 04D5F91E286C4542000A5A4E /* Recommendation.swift */; };
04D5F927286C4542000A5A4E /* Recommendation.swift in Sources */ = {isa = PBXBuildFile; fileRef = 04D5F91E286C4542000A5A4E /* Recommendation.swift */; };
04D5F928286C4542000A5A4E /* Recommendation.swift in Sources */ = {isa = PBXBuildFile; fileRef = 04D5F91E286C4542000A5A4E /* Recommendation.swift */; };
04E031CF28BD0EF000450D38 /* RemoteCommandCenter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 04E031CE28BD0EF000450D38 /* RemoteCommandCenter.swift */; };
04E031D028BD0EF000450D38 /* RemoteCommandCenter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 04E031CE28BD0EF000450D38 /* RemoteCommandCenter.swift */; };
04E031D128BD0EF000450D38 /* RemoteCommandCenter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 04E031CE28BD0EF000450D38 /* RemoteCommandCenter.swift */; };
04E031D228BD0EF000450D38 /* RemoteCommandCenter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 04E031CE28BD0EF000450D38 /* RemoteCommandCenter.swift */; };
04E031D328BD0EF000450D38 /* RemoteCommandCenter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 04E031CE28BD0EF000450D38 /* RemoteCommandCenter.swift */; };
04E4DEEB283678C900698BF8 /* ServiceMessage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 04E4DEEA283678C900698BF8 /* ServiceMessage.swift */; };
04E4DEEC283678C900698BF8 /* ServiceMessage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 04E4DEEA283678C900698BF8 /* ServiceMessage.swift */; };
04E4DEED283678C900698BF8 /* ServiceMessage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 04E4DEEA283678C900698BF8 /* ServiceMessage.swift */; };
Expand Down Expand Up @@ -2672,6 +2677,7 @@
0451ECE228742D8000E89975 /* UIWindowScene+PlaySRG.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UIWindowScene+PlaySRG.swift"; sourceTree = "<group>"; };
04D5477C27BFFE79003D1BC2 /* LoadingCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = LoadingCell.swift; sourceTree = "<group>"; };
04D5F91E286C4542000A5A4E /* Recommendation.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Recommendation.swift; sourceTree = "<group>"; };
04E031CE28BD0EF000450D38 /* RemoteCommandCenter.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = RemoteCommandCenter.swift; sourceTree = "<group>"; };
04E4DEEA283678C900698BF8 /* ServiceMessage.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ServiceMessage.swift; sourceTree = "<group>"; };
05F9A586175D559FBBCA636E /* Pods-Play SRG-iOS-Play RTS.appstore.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Play SRG-iOS-Play RTS.appstore.xcconfig"; path = "Pods/Target Support Files/Pods-Play SRG-iOS-Play RTS/Pods-Play SRG-iOS-Play RTS.appstore.xcconfig"; sourceTree = "<group>"; };
08013EB325DC28F60099A6E8 /* TVServices.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = TVServices.framework; path = Platforms/AppleTVOS.platform/Developer/SDKs/AppleTVOS14.3.sdk/System/Library/Frameworks/TVServices.framework; sourceTree = DEVELOPER_DIR; };
Expand Down Expand Up @@ -3852,6 +3858,7 @@
08BDB5B1228D520000335898 /* PushService+Private.h */,
6F0850F226256A7700B4E410 /* Reachability.h */,
6F0850F326256A7700B4E410 /* Reachability.m */,
04E031CE28BD0EF000450D38 /* RemoteCommandCenter.swift */,
6F978B4F2849C3CA003061E8 /* ScrollableContent.h */,
6F978B502849C3CA003061E8 /* ScrollableContent.m */,
08AF947E217D27E40028B082 /* SharingItem.h */,
Expand Down Expand Up @@ -8472,6 +8479,7 @@
6F58903426AED4CD00553C24 /* Environment.swift in Sources */,
6FCA5BD627D9DE0900916D0B /* DiskInfoFooterView.swift in Sources */,
6FB899FF26335B090012F1B0 /* Stack.swift in Sources */,
04E031CF28BD0EF000450D38 /* RemoteCommandCenter.swift in Sources */,
6FD4C2D6268B6CBB00F06F63 /* SimpleButton.swift in Sources */,
6F16C80C26025945006F685A /* PageViewModel.swift in Sources */,
08F5DB10262DC7F700F717D0 /* Logger.swift in Sources */,
Expand Down Expand Up @@ -8505,6 +8513,7 @@
6F6E9062283E6EB10049FEEE /* Highlight.swift in Sources */,
6F2F556C27B40967003DC9C0 /* NowArrowView.swift in Sources */,
E66BEC1D1DA7FCED00AD4450 /* MediaPlayerViewController.m in Sources */,
04E031D028BD0EF000450D38 /* RemoteCommandCenter.swift in Sources */,
6F2DE05426440FB10059335E /* ActivityIndicator.swift in Sources */,
0821D53F227F5ED300FC091F /* DeepLinkService.m in Sources */,
6FD4C2D7268B6CBB00F06F63 /* SimpleButton.swift in Sources */,
Expand Down Expand Up @@ -8754,6 +8763,7 @@
6F6E9063283E6EB10049FEEE /* Highlight.swift in Sources */,
6F2F556D27B40967003DC9C0 /* NowArrowView.swift in Sources */,
E66BEC1E1DA7FCED00AD4450 /* MediaPlayerViewController.m in Sources */,
04E031D128BD0EF000450D38 /* RemoteCommandCenter.swift in Sources */,
6F2DE05526440FB10059335E /* ActivityIndicator.swift in Sources */,
0821D540227F5ED300FC091F /* DeepLinkService.m in Sources */,
6FD4C2D8268B6CBB00F06F63 /* SimpleButton.swift in Sources */,
Expand Down Expand Up @@ -9003,6 +9013,7 @@
6F6E9064283E6EB10049FEEE /* Highlight.swift in Sources */,
6F2F556E27B40967003DC9C0 /* NowArrowView.swift in Sources */,
E66BEC1F1DA7FCED00AD4450 /* MediaPlayerViewController.m in Sources */,
04E031D228BD0EF000450D38 /* RemoteCommandCenter.swift in Sources */,
6F2DE05626440FB20059335E /* ActivityIndicator.swift in Sources */,
0821D541227F5ED300FC091F /* DeepLinkService.m in Sources */,
6FD4C2D9268B6CBB00F06F63 /* SimpleButton.swift in Sources */,
Expand Down Expand Up @@ -9313,6 +9324,7 @@
6FD633E21FFBC0BE00875BE5 /* GoogleCastMiniPlayerView.m in Sources */,
6FB9B3DA26CA88AD0065092F /* TransluscentHeaderView.swift in Sources */,
6F56F9F8247C407100B2387B /* ChannelServiceSetup.m in Sources */,
04E031D328BD0EF000450D38 /* RemoteCommandCenter.swift in Sources */,
6FC0C699245FF06D00B44CAE /* ProgramHeaderView.m in Sources */,
6F010E15286607450024A745 /* SearchSettingsBucketCell.swift in Sources */,
6F33E6172860AF0200724E76 /* Navigation.swift in Sources */,
Expand Down